linnealovespie/aemp-seattle
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

CCFS Database #18

Merged
linnealovespie merged 6 commits from linnealovespie/database into main 2026-01-22 00:14:58 +00:00
Conversation 5 Commits 6 Files Changed 7
+130 -179
linnealovespie commented 2026-01-21 02:54:28 +00:00
Owner
Copy Link
Copy Source

Refactors corp_owners.py to use our own copy of the CCFS database instead of querying (and getting blocked by) the online CCFS portal.

Adds test.py in processors folder that's helpful for testing changes to corp_owners.py by comparing results with known results for buildings owned by Goodman Real Estate.

Addresses issue #17 for now, but would still be good to make a more robust test framework in the future.

Refactors `corp_owners.py` to use our own copy of the CCFS database instead of querying (and getting blocked by) the online CCFS portal. Adds `test.py` in processors folder that's helpful for testing changes to `corp_owners.py` by comparing results with known results for buildings owned by Goodman Real Estate. Addresses issue #17 for now, but would still be good to make a more robust test framework in the future.
linnealovespie added 1 commit 2026-01-21 02:54:28 +00:00
Refactor to use our own database copy of CCFS instead of querying the CCFS website 0281c544f8
linnealovespie added 1 commit 2026-01-21 02:54:34 +00:00
Merge branch 'main' into linnealovespie/database 0002898009
linnealovespie added 1 commit 2026-01-21 02:58:43 +00:00
add dotenv to requirements 56c1ba7676
linnealovespie requested review from jessib 2026-01-21 02:59:11 +00:00
linnealovespie added 1 commit 2026-01-21 03:07:49 +00:00
update readme 01a4de1436
jessib commented 2026-01-21 03:30:09 +00:00
Collaborator
Copy Link
Copy Source

It seems good idea to add .env to .gitignore if folks are going to be having that file.

It seems good idea to add `.env` to `.gitignore` if folks are going to be having that file.
linnealovespie added 1 commit 2026-01-21 03:40:15 +00:00
gitignore 39fe1c17c1
linnealovespie commented 2026-01-21 03:41:46 +00:00
Author
Owner
Copy Link
Copy Source

It seems good idea to add .env to .gitignore if folks are going to be having that file.

Oh good point it somehow didn't get added to the commit, added the gitignore now.

> It seems good idea to add `.env` to `.gitignore` if folks are going to be having that file. Oh good point it somehow didn't get added to the commit, added the gitignore now.
jessib reviewed 2026-01-21 04:05:36 +00:00
requirements.txt
@@ -31,2 +31,4 @@
minio==7.2.16
pycryptodome==3.23.0
dotenv==0.9.9
python-dotenv==1.2.1
jessib commented 2026-01-21 04:05:36 +00:00
Collaborator
Copy Link
Copy Source

Should psycopg2 be added here? I needed to manually install but maybe that was something with my setup.

Should `psycopg2` be added here? I needed to manually install but maybe that was something with my setup.
linnealovespie commented 2026-01-21 04:12:12 +00:00
Author
Owner
Copy Link
Copy Source

Yes it should good catch. I'd like to add another todo later to automate this process because slip ups like this happen, but my pip freeze command looks funky when trying to generate this file.

Yes it should good catch. I'd like to add another todo later to automate this process because slip ups like this happen, but my `pip freeze` command looks funky when trying to generate this file.
linnealovespie marked this conversation as resolved
linnealovespie added 1 commit 2026-01-21 04:11:11 +00:00
reqs 66f2ac404a
jessib approved these changes 2026-01-22 00:13:46 +00:00
jessib left a comment
Collaborator
Copy Link
Copy Source

I didn't give it the most thorough review, but looks good and doesn't seem risky.

I didn't give it the most thorough review, but looks good and doesn't seem risky.
❤️ 1
linnealovespie merged commit 5a37d38130 into main 2026-01-22 00:14:58 +00:00
jessib reviewed 2026-02-08 17:02:33 +00:00
processors/corp_owners.py
@@ -225,4 +160,2 @@
for owner in owner_list:
owner = owner.strip() # Clean owner name slightly
matches = self._get_potential_company_name_matches(owner)
temp_exact, temp_potential = self._separate_search_results(matches)
jessib commented 2026-02-08 17:02:33 +00:00
Collaborator
Copy Link
Copy Source

@linnealovespie : I happened to be looking at this when working on my PR, and it seems like _get_potential_company_name_matches is now longer called so can be removed.

@linnealovespie : I happened to be looking at this when working on my PR, and it seems like `_get_potential_company_name_matches` is now longer called so can be removed.
Sign in to join this conversation.
Reviewers
No Reviewers
jessib
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ammaratef45 Hedgewig1 jessib Proven-Paradox rv32ima linnealovespie (April)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: linnealovespie/aemp-seattle#18