lumbung.space/konfluks
0
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Support OPDS feeds, sanitize yaml frontmatter & relicense to AGPL #26

Closed
r wants to merge 0 commits from master into master
pull from: master
merge into: lumbung.space:master
Conversation 4 Commits - Files Changed -
r commented 2022-02-16 14:01:42 +00:00 (Migrated from git.autonomic.zone)
Copy Link
No description provided.
knoflook commented 2022-02-17 15:31:11 +00:00 (Migrated from git.autonomic.zone)
Copy Link

I introduced a merge conflict while doing a hotfix on feed.py to escape ". I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!

I introduced a merge conflict while doing a hotfix on `feed.py` to escape `"`. I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!
r commented 2022-02-17 17:02:40 +00:00 (Migrated from git.autonomic.zone)
Copy Link

I introduced a merge conflict while doing a hotfix on feed.py to escape ". I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!

Yes I saw how you resolved it in the hashtag feed and thought to generalize it as a method because the quotes can happen in a lot of places.

We could even split it off to a separate util script so the method can be imported by the other scripts?

There might be one or two other things that could go to such a util script. However, while there is a lot that the scripts do very very similarly, it tends to be not similar enough, to make a general method. It is also why I rolled OPDS in to the feed.py..

> I introduced a merge conflict while doing a hotfix on `feed.py` to escape `"`. I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it! Yes I saw how you resolved it in the hashtag feed and thought to generalize it as a method because the quotes can happen in a lot of places. We could even split it off to a separate util script so the method can be imported by the other scripts? There might be one or two other things that could go to such a util script. However, while there is a lot that the scripts do very very similarly, it tends to be not similar enough, to make a general method. It is also why I rolled OPDS in to the feed.py..
knoflook commented 2022-02-21 10:16:34 +00:00 (Migrated from git.autonomic.zone)
Copy Link

We could even split it off to a separate util script so the method can be imported by the other scripts?

I think it can stay as-is, I'm making one small change to the code to improve performance.

> We could even split it off to a separate util script so the method can be imported by the other scripts? I think it can stay as-is, I'm making one small change to the code to improve performance.
knoflook commented 2022-03-04 14:50:43 +00:00 (Migrated from git.autonomic.zone)
Copy Link

conflict resolved 😎

conflict resolved 😎

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot cas coopcloud kawaiipunk knoflook notplants rscmbbng trav
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lumbung.space/konfluks#26
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?