p4u1/abra
0
0
Fork 0
forked from toolshed/abra
Code Pull Requests Activity

fix: skip name validation for remote recipes

Browse Source 
See toolshed/abra#601
This commit is contained in:
decentral1se
2025-08-18 08:56:52 +02:00
parent 60b3af1fa4
commit 1aa7016789
3 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cli/internal/validate.go
View File

@ -59,8 +59,10 @@ func ValidateRecipe(args []string, cmdName string) recipe.Recipe {
} }
if _, ok := knownRecipes[recipeName]; !ok { if _, ok := knownRecipes[recipeName]; !ok {
if !strings.Contains(recipeName, "/") {
log.Fatalf("no recipe '%s' exists?", recipeName) log.Fatalf("no recipe '%s' exists?", recipeName)
} }
}
chosenRecipe := recipe.Get(recipeName) chosenRecipe := recipe.Get(recipeName)
if err := chosenRecipe.EnsureExists(); err != nil { if err := chosenRecipe.EnsureExists(); err != nil {

10
tests/integration/recipe_lint.bats
View File

@ -22,14 +22,16 @@ teardown(){
} }
@test "retrieve recipe if missing" { @test "retrieve recipe if missing" {
run rm -rf "$ABRA_DIR/recipes/$TEST_RECIPE" if [[ -d "$ABRA_DIR/recipe/custom-html" ]]; then
run rm -rf "$ABRA_DIR/recipes/custom-html"
assert_success assert_success
assert_not_exists "$ABRA_DIR/recipes/$TEST_RECIPE" assert_not_exists "$ABRA_DIR/recipes/custom-html"
fi
run $ABRA recipe lint "$TEST_RECIPE" run $ABRA recipe lint custom-html
assert_success assert_success
assert_exists "$ABRA_DIR/recipes/$TEST_RECIPE" assert_exists "$ABRA_DIR/recipes/custom-html"
} }
@test "bail if unstaged changes and no --chaos" { @test "bail if unstaged changes and no --chaos" {

10
tests/integration/recipe_upgrade.bats
View File

@ -30,15 +30,17 @@ teardown(){
} }
@test "retrieve recipe if missing" { @test "retrieve recipe if missing" {
run rm -rf "$ABRA_DIR/recipes/$TEST_RECIPE" if [[ -d "$ABRA_DIR/recipe/custom-html" ]]; then
run rm -rf "$ABRA_DIR/recipes/custom-html"
assert_success assert_success
assert_not_exists "$ABRA_DIR/recipes/$TEST_RECIPE" assert_not_exists "$ABRA_DIR/recipes/custom-html"
fi
run $ABRA recipe upgrade "$TEST_RECIPE" --no-input run $ABRA recipe upgrade "custom-html" --no-input
assert_success assert_success
assert_output --partial 'can upgrade service: app' assert_output --partial 'can upgrade service: app'
assert_exists "$ABRA_DIR/recipes/$TEST_RECIPE" assert_exists "$ABRA_DIR/recipes/custom-html"
} }
@test "error if unstaged changes" { @test "error if unstaged changes" {