fix: error handling in abra recipe fetch -a #601

decentral1se · 2025-08-18T06:02:43Z

decentral1se commented

2025-08-18 06:02:43 +00:00

Working on #582 and did some refactoring.

Only returns errors from recipe.Get so catalogue generation doesn't explode
Always validate recipe name (using catalogue local/remote) so we give better error messages

~~Gonna run the entire integration suite for this one...~~ LGTM!

Working on https://git.coopcloud.tech/toolshed/abra/issues/582 and did some refactoring. * Only returns errors from `recipe.Get` so catalogue generation doesn't explode * Always validate recipe name (using catalogue local/remote) so we give better error messages ~~Gonna run the entire integration suite for this one...~~ LGTM!

decentral1se added 3 commits 2025-08-18 06:02:44 +00:00

refactor: always validate recipe 110f261fad

This can slow things significantly down by requiring the catalogue and
if you don't have that, cause a slow `git clone`. However, the current
behvaiour is very confusing because it never actually checks if what the
user passes is actually a recipe. `abra recipe fetch DOESNTEXIST` gives
a better error to the user now. I'm hoping we can speed up the catalogue
handling at some point.

refactor: move ensureCtx closer to usage 5274d0f37d

fix: return error, not log.Fatal

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

e2b4fffa65