fix: Does not crash when an image has no tag

moved fork
fix: Allows multiple protocols on one port
2026-02-13 11:24:22 +01:00 · 2026-02-13 09:29:01 +00:00 · 2026-02-13 09:29:01 +00:00 · 2026-02-13 05:52:56 +00:00 · 2026-02-12 05:13:22 +00:00 · 2026-02-05 14:52:56 +00:00
4 changed files with 578 additions and 555 deletions
@@ -165,7 +165,13 @@ func GetImagesForStack(cl *dockerClient.Client, app appPkg.App) (map[string]stri
 			}

 			imageBaseName := reference.Path(imageParsed)
-			imageTag := imageParsed.(reference.NamedTagged).Tag()
+			namedTag, ok := imageParsed.(reference.NamedTagged)
+			if !ok {
+				// This is an image without a tag
+				images[imageBaseName] = ""
+				continue
+			}
+			imageTag := namedTag.Tag()

 			existingImageVersion, ok := images[imageBaseName]
 			if !ok {
@@ -282,7 +288,13 @@ func GatherImagesForDeploy(cl *dockerClient.Client, app appPkg.App, compose *com
 		}

 		imageBaseName := reference.Path(imageParsed)
-		imageTag := imageParsed.(reference.NamedTagged).Tag()
+		namedTag, ok := imageParsed.(reference.NamedTagged)
+		if !ok {
+			// This is an image without a tag
+			newImages[imageBaseName] = ""
+			continue
+		}
+		imageTag := namedTag.Tag()

 		existingImageVersion, ok := newImages[imageBaseName]
 		if !ok {
@@ -623,3 +623,16 @@ teardown(){
  assert_output --partial "tcp=1312"
  assert_output --partial "udp=1312"
 }
+
+# bats test_tags=slow
+@test "does not crash when docker image has no tag" {
+  run sed -i 's/TYPE=abra-test-recipe:.*/TYPE=git.coopcloud.tech\/p4u1\/abra-test-recipe:b29422d5a344ea45df271443182f775ea82b4da8/g' \
+    "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
+  assert_success
+
+  run bash -c "printf '\nCOMPOSE_FILE=\"\$COMPOSE_FILE:compose.no-image-tag.yml\"' >> $ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
+  assert_success
+
+  run $ABRA app deploy "$TEST_APP_DOMAIN" --no-input
+  assert_success
+}
Author	SHA1	Message	Date
p4u1	23268a0e92	fix: Does not crash when an image has no tag	2026-02-13 11:24:22 +01:00
p4u1	d60d426752	moved fork	2026-02-13 09:29:01 +00:00
p4u1	0e273de8f6	fix: Allows multiple protocols on one port	2026-02-13 09:29:01 +00:00
ChasquiLabo	ab32118bfe	chore: translation using Weblate (Spanish) Currently translated at 75.0% (856 of 1141 strings) Translation: Co-op Cloud/abra Translate-URL: https://translate.coopcloud.tech/projects/co-op-cloud/abra/es/	2026-02-13 05:52:56 +00:00
ChasquiLabo	683396d75a	chore: translation using Weblate (Spanish) Currently translated at 58.7% (670 of 1141 strings) Translation: Co-op Cloud/abra Translate-URL: https://translate.coopcloud.tech/projects/co-op-cloud/abra/es/	2026-02-12 05:13:22 +00:00
ChasquiLabo	4db6755f0d	chore: translation using Weblate (Spanish) Currently translated at 30.2% (345 of 1141 strings) Translation: Co-op Cloud/abra Translate-URL: https://translate.coopcloud.tech/projects/co-op-cloud/abra/es/	2026-02-05 14:52:56 +00:00