p4u1/docker-cli
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

builder/remotecontext: remove unused named and "naked" returns

Browse Source 
Also renamed some vars for clarity, renamed a error-returns to prevent
shadowing, and fixed some linter warnings about unhandled errors.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2023-12-28 11:58:52 +01:00
parent 75f791d904
commit a10a1e619b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cli/command/image/build/internal/git/gitutils.go
View File

@ -46,7 +46,7 @@ func Clone(remoteURL string, opts ...CloneOption) (string, error) {
return repo.clone()
}
func (repo gitRepo) clone() (checkoutDir string, err error) {
func (repo gitRepo) clone() (checkoutDir string, retErr error) {
fetch := fetchArgs(repo.remote, repo.ref)
root, err := os.MkdirTemp("", "docker-build-git")
@ -55,8 +55,8 @@ func (repo gitRepo) clone() (checkoutDir string, err error) {
}
defer func() {
if err != nil {
os.RemoveAll(root)
if retErr != nil {
_ = os.RemoveAll(root)
}
}()