p4u1/docker-cli
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix linting issues

Browse Source 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2025-07-16 16:19:44 +02:00
parent 8d2ccc128a
commit e34616574f
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cli/command/image/build/internal/git/gitutils.go
View File

@ -148,6 +148,9 @@ func supportsShallowClone(remoteURL string) bool {
// Try a HEAD request and fallback to a Get request on error
res, err := http.Head(serviceURL) // #nosec G107
if err == nil {
_ = res.Body.Close()
}
if err != nil || res.StatusCode != http.StatusOK {
res, err = http.Get(serviceURL) // #nosec G107
if err == nil {

16
cli/command/image/build/internal/git/gitutils_test.go
View File

@ -350,15 +350,15 @@ func TestValidGitTransport(t *testing.T) {
"github.com/docker/docker",
}
for _, url := range gitUrls {
if !isGitTransport(url) {
t.Fatalf("%q should be detected as valid Git prefix", url)
for _, u := range gitUrls {
if !isGitTransport(u) {
t.Fatalf("%q should be detected as valid Git prefix", u)
}
}
for _, url := range incompleteGitUrls {
if isGitTransport(url) {
t.Fatalf("%q should not be detected as valid Git prefix", url)
for _, u := range incompleteGitUrls {
if isGitTransport(u) {
t.Fatalf("%q should not be detected as valid Git prefix", u)
}
}
}
@ -371,8 +371,8 @@ func TestGitInvalidRef(t *testing.T) {
"git@g.com:a/b.git#with space",
}
for _, url := range gitUrls {
_, err := Clone(url)
for _, u := range gitUrls {
_, err := Clone(u)
assert.Assert(t, err != nil)
// On Windows, git has different case for the "invalid refspec" error,
// so we can't use ErrorContains.