refactor!: --problems/p goes away

Follow up for coop-cloud/abra#413

cli/server/list.go

@@ -12,20 +12,11 @@ import (
 	"github.com/urfave/cli"
 )
 
-var problemsFilter bool
-
-var problemsFilterFlag = &cli.BoolFlag{
-	Name:        "problems, p",
-	Usage:       "Show only servers with potential connection problems",
-	Destination: &problemsFilter,
-}
-
 var serverListCommand = cli.Command{
 	Name:    "list",
 	Aliases: []string{"ls"},
 	Usage:   "List managed servers",
 	Flags: []cli.Flag{
-		problemsFilterFlag,
 		internal.DebugFlag,
 		internal.MachineReadableFlag,
 		internal.OfflineFlag,
@@ -38,7 +29,7 @@ var serverListCommand = cli.Command{
 			log.Fatal(err)
 		}
 
-		tableColumns := []string{"name", "host", "user", "port"}
+		tableColumns := []string{"name", "host"}
 		table := formatter.CreateTable(tableColumns)
 
 		serverNames, err := config.ReadServerNames()
@@ -64,47 +55,29 @@ var serverListCommand = cli.Command{
 					if sp.Host == "" {
 						sp.Host = "unknown"
 					}
-					if sp.User == "" {
-						sp.User = "unknown"
-					}
-					if sp.Port == "" {
-						sp.Port = "unknown"
-					}
 
-					row = []string{serverName, sp.Host, sp.User, sp.Port}
+					row = []string{serverName, sp.Host}
 				}
 			}
 
 			if len(row) == 0 {
 				if serverName == "default" {
-					row = []string{serverName, "local", "n/a", "n/a"}
+					row = []string{serverName, "local"}
 				} else {
-					row = []string{serverName, "unknown", "unknown", "unknown"}
+					row = []string{serverName, "unknown"}
 				}
 			}
 
-			if problemsFilter {
-				for _, val := range row {
-					if val == "unknown" {
-						table.Append(row)
-						break
-					}
-				}
-			} else {
-				table.Append(row)
-			}
+			table.Append(row)
 		}
 
 		if internal.MachineReadable {
 			table.JSONRender()
-		} else {
-			if problemsFilter && table.NumLines() == 0 {
-				log.Info("all servers wired up correctly 👏")
-			} else {
-				table.Render()
-			}
+			return nil
 		}
 
+		table.Render()
+
 		return nil
 	},
 }