toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

refactor!: drop all SSH opts / config handling #413

Merged
decentral1se merged 1 commits from ssh-host-config-bye into main 2024-06-22 12:16:03 +00:00
Conversation 1 Commits 1 Files Changed 4 +19 -84
decentral1se commented 2024-06-20 07:23:39 +00:00
Owner
Copy Link

See coop-cloud/organising#601 coop-cloud/organising#482

@3wordchant @moritz could yall test this? 🤞

This drops all ~/.ssh/config parsing and drops the hardcoded timeout value (finally!).

I've done some minor manual testing and it seems to work? Unsure what we'll run into tho...

The only change the user will see is in resulting Docker context strings:

  • Before: ssh://decentral1se@test.foo.org:12345
  • After: ssh://test.foo.org

If this works, there is also a docs patch required to clarify how we're going forward with SSH handling.

See https://git.coopcloud.tech/coop-cloud/organising/issues/601 https://git.coopcloud.tech/coop-cloud/organising/issues/482 @3wordchant @moritz could yall test this? 🤞 This drops all `~/.ssh/config` parsing and drops the hardcoded timeout value (finally!). I've done some minor manual testing and it seems to work? Unsure what we'll run into tho... The only change the user will see is in resulting Docker context strings: * Before: `ssh://decentral1se@test.foo.org:12345` * After: `ssh://test.foo.org` If this works, there is also a docs patch required to clarify how we're going forward with SSH handling.
🎉 2
decentral1se requested review from 3wordchant 2024-06-20 07:23:49 +00:00
decentral1se requested review from moritz 2024-06-20 07:23:50 +00:00
decentral1se force-pushed ssh-host-config-bye from b8e6b61c5f to aa3910f8df 2024-06-21 15:16:58 +00:00 Compare
decentral1se changed title from WIP: refactor!: drop all SSH opts / config handling to refactor!: drop all SSH opts / config handling 2024-06-22 12:15:18 +00:00
decentral1se commented 2024-06-22 12:15:40 +00:00
Author
Owner
Copy Link

Aight I'm gonna merge this into main to keep testing it as we go, lemme know if you see bugs!

Aight I'm gonna merge this into main to keep testing it as we go, lemme know if you see bugs!
decentral1se merged commit aa3910f8df into main 2024-06-22 12:16:03 +00:00
decentral1se deleted branch ssh-host-config-bye 2024-06-22 12:16:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
3wordchant
moritz
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#413
No description provided.
Delete Branch "ssh-host-config-bye"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?