Setting a higher ConnectTimeout for ssh #482

New Issue

moritz · 2023-08-25T14:46:32Z

moritz commented

2023-08-25 14:46:32 +00:00

When I generate all the secrets for authentik (about 15) it takes so long that I hit the connection timeout of 5 seconds.
Would it cause any problems if we simply set the connection timeout to a fixed value of 30s? Or would a parameterized connection timeout be better?
0c6a7cc0b8/pkg/upstream/commandconn/connection.go (L21)

When I generate all the secrets for authentik (about 15) it takes so long that I hit the connection timeout of 5 seconds. Would it cause any problems if we simply set the connection timeout to a fixed value of 30s? Or would a parameterized connection timeout be better? https://git.coopcloud.tech/coop-cloud/abra/src/commit/0c6a7cc0b881b487ed40471db2e57fb1bfbd3c96/pkg/upstream/commandconn/connection.go#L21

decentral1se commented

2023-08-26 07:54:03 +00:00

Ah yeh, that is quite low. I think it is set like this so that failed SSH connections get faster feedback, e.g. if you don't have your keys configured correctly, you only wait 5 seconds to hear about it. I don't know how hard it would be to pass down a parametrized value for specific cases but perhaps this could be something that could go in https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/pkg/runtime/config.go

decentral1se added the

question

abra

labels 2023-08-26 07:54:36 +00:00

moritz referenced this issue from a commit

2023-11-30 15:37:09 +00:00

fix(ssh): increase connection timeout #482

decentral1se commented

2024-03-03 14:45:09 +00:00

🌻 bats -Tp tests/integration/server_add.bats
server_add.bats
✓ add new server [2466]
✓ error if using domain and --local together [370]
✓ create local server [2593]
✓ create local server fails when no docker swarm [387]
✓ cleanup when cannot add server [181061]
5 tests, 0 failures in 188 seconds

So, the "cleanup when cannot add server" is now taking +1 minute to run because the timeout is so large. @moritz do you have any proposals on how to make this value configurable? Could this value also be read from the ~/.ssh/config as a global configuration? Then we could revert to the small default.

> 🌻 bats -Tp tests/integration/server_add.bats > server_add.bats > ✓ add new server [2466] > ✓ error if using domain and --local together [370] > ✓ create local server [2593] > ✓ create local server fails when no docker swarm [387] > ✓ cleanup when cannot add server [181061] > 5 tests, 0 failures in 188 seconds So, the "cleanup when cannot add server" is now taking +1 minute to run because the timeout is so large. @moritz do you have any proposals on how to make this value configurable? Could this value also be read from the `~/.ssh/config` as a global configuration? Then we could revert to the small default.

~~decentral1se referenced this issue from coop-cloud/abra 2024-03-03 16:01:00 +00:00~~

fix-integration-tests #403

~~p4u1 referenced this issue 2024-03-11 12:57:14 +00:00~~

Release abra 0.9.0-beta #573

~~decentral1se referenced this issue 2024-03-27 06:27:25 +00:00~~

New abra release planning #583

decentral1se referenced this issue

2024-03-28 13:54:55 +00:00

New abra release planning #583

decentral1se referenced this issue

2024-04-01 11:40:28 +00:00

Gathering ssh config connection issues #601