• Joined on 2023-06-26
rix deleted branch add-secret-length-linting from rix/abra 2024-04-06 22:15:53 +00:00
rix commented on pull request coop-cloud/abra#359 2024-04-06 20:15:15 +00:00
fix: add warning for long secret names

Hey, I've just pushed up some new stuff that I think works with the flow moving the verification as part of the read secret config since we seem to have all the data we need now. I've also added…

rix pushed to add-secret-length-linting at rix/abra 2024-04-06 20:12:33 +00:00
ba956f340a Attempted rework to match new code.
rix pushed to add-secret-length-linting at rix/abra 2024-04-06 10:42:22 +00:00
eea47f9099 Attempt to fix post merge problems.
296bed9704 Merge remote-tracking branch 'coopcloud/main' into add-secret-length-linting
63ea58ffaa add relevant command to error message
2ecace3e90 fix: add missing packages on final layer
d5ac3958a4 feat: add retries to app volume remove
Compare 78 commits »
rix commented on pull request coop-cloud/abra#359 2024-04-06 10:38:00 +00:00
fix: add warning for long secret names

Sorry or the delay in getting back to you, I did reply to my e-mail notification thinking that the comment would show up but it seemingly hasn't. I've been a bit burned out for a while but I'm…

rix pushed to main at coop-cloud/abra-test-recipe 2023-10-11 16:21:10 +00:00
b1c16d9c4d Add long secret test case (commented)
rix commented on pull request coop-cloud/abra-test-recipe#2 2023-10-10 20:52:17 +00:00
Add test case for long secrets.

@rix Feel free to merge / hack / send commits directly to main for this repo!

I'm pretty sure you have the permissions.

It looks like the repo got renamed since I started working on it…

rix commented on pull request coop-cloud/abra-test-recipe#2 2023-10-10 20:49:41 +00:00
Add test case for long secrets.

Fixed : )

rix pushed to add-too-long-secret-test-case at rix/abra-integration-test-recipe 2023-10-10 20:48:53 +00:00
180122518f Add SECRET_ prefix to secret version.
9d82fb8704 Add test case for long secrets.
8f9dd819f7 fix: use new name
0c13aae2e4 feat: further env var / comment tests
1e8ec66339 feat: env var with comment
Compare 11 commits »
rix pushed to add-too-long-secret-test-case at rix/abra-integration-test-recipe 2023-10-10 20:19:03 +00:00
09f1708a4d Add SECRET_ prefix to secret version.
rix pushed to add-secret-length-linting at rix/abra 2023-10-05 17:25:09 +00:00
29bd057460 Add common check to generate secrets command.
66cf63a665 Move secret checking to a shared location.
Compare 2 commits »
rix commented on pull request coop-cloud/abra#359 2023-10-04 18:15:16 +00:00
fix: add warning for long secret names

No worries @rix! Doing great work here. If you don't --secrets on abra app new then when you deploy, it will fail with missing secrets. Not very gracefully actually, but I'll open a ticket…

rix commented on pull request coop-cloud/abra#359 2023-10-04 18:13:09 +00:00
fix: add warning for long secret names

Done : )

rix commented on pull request coop-cloud/abra#359 2023-10-04 18:12:57 +00:00
fix: add warning for long secret names

I've made it drop out after the first error now but I guess the side effect is that if there's more than one long secret it will be a bit of a whack-a-mole to find them all but I guess it's a…

rix commented on pull request coop-cloud/abra#359 2023-10-04 18:11:45 +00:00
fix: add warning for long secret names

Removed, it helped me with debugging and I thought that maybe it might help explain the logic but you're right that's it's probably not helpful for the day to day experience.

rix commented on pull request coop-cloud/abra#359 2023-10-04 18:11:04 +00:00
fix: add warning for long secret names

Done

rix commented on pull request coop-cloud/abra#359 2023-10-04 18:10:55 +00:00
fix: add warning for long secret names

Think I've got this one now but let me know if I misinterpreted which line you were talking about : )

rix pushed to add-secret-length-linting at rix/abra 2023-10-04 18:10:22 +00:00
2abb7264b8 Added 'secret' before error to make it clear it's a secret.
rix pushed to add-secret-length-linting at rix/abra 2023-10-04 18:07:13 +00:00
344590b19b Switch to using const for max docker secret length.
f85a3e40aa Switch to using const for max sanitised app length.
2583fe2861 Drop debug logging and fail on first secret that is too long.
Compare 3 commits »
rix commented on pull request coop-cloud/abra#359 2023-10-03 21:06:57 +00:00
fix: add warning for long secret names

Some more progress, the error now shows up before the whole thing falls over which is an improvement! I've created the data for an integration test but not the intergation test itself as of…