toolshed/abra-bash
Archived
5
0
Fork 3
Code Pull Requests Releases Activity

Show git digest in abra version if we're running a development version #103

Merged
decentral1se merged 2 commits from digest-version into main 2021-03-17 11:48:46 +00:00
Conversation 1 Commits 2 Files Changed 2 +7 -2
3wordchant commented 2021-03-16 11:05:19 +00:00
Owner
Copy Link

Closes #100

This isn't perfect, because it'll blow up if:

  1. ~/.local/bin/abra is a symlink to the downloaded abra script, but not a git checkout
  2. Or if we run abra from the checkout, not using a symlink

But neither of these situations is likely gonna be that common.

In the simple case:

$ abra version
0.5.0-23c8521

Whaddya reck?

Closes #100 This isn't perfect, because it'll blow up if: 1. `~/.local/bin/abra` is a symlink to the downloaded `abra` script, but not a git checkout 2. Or if we run abra from the checkout, not using a symlink But neither of these situations is likely gonna be that common. In the simple case: ``` $ abra version 0.5.0-23c8521 ``` Whaddya reck?
3wordchant added 2 commits 2021-03-16 11:05:20 +00:00
Include git digest in dev version output 8b4141670c 
Re: #100
Update CHANGELOG
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c00319ab01
decentral1se approved these changes 2021-03-16 11:26:07 +00:00
decentral1se left a comment
Owner

Nice! LGTM!

Or if we run abra from the checkout, not using a symlink

Wanna update the README to remove the hacking tip that says just run ./abra? I think this is fine since we give clear guidelines how to get hacking on it (just use --dev)

Nice! LGTM! > Or if we run abra from the checkout, not using a symlink Wanna update the README to remove the hacking tip that says just run `./abra`? I think this is fine since we give clear guidelines how to get hacking on it (just use `--dev`)
decentral1se merged commit 293d3ff558 into main 2021-03-17 11:48:46 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
breaking-change
Anything that breaks the existing API
bug
Something is not working
CI/CD
Anything to do with testing and infra
design
Anything to with UX of this tool
documentation
Documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
plugin
Related to the plugin architecture
question
More information is needed
secrets
Everything to do with docker secrets
shell-completion
To do with shell completion
versioning
All the things to do with versioning apps
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband moritz p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra-bash#103
No description provided.
Delete Branch "digest-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?