toolshed/abra-bash
toolshed/abra-bash
Archived
5
0
Fork 3
Code Pull Requests Releases Activity

Possible fix to invalid length "20"? #160

Closed
3wordchant wants to merge 1 commits from fix-pwgen into main
pull from: fix-pwgen
merge into: toolshed:main
Conversation 4 Commits 1 Files Changed 1 +1 -1
3wordchant commented 2021-05-04 06:44:22 +00:00
Owner
Copy Link

Before:

$ abra app minio secret generate --all --pass
...
Invalid length "20"
# Blows up 💣

After: works

Could just be my system though. @decentral1se what's it lookin like your end?

Interestingly pwgen -s "20" 1 works fine outside the script.

Before: ``` $ abra app minio secret generate --all --pass ... Invalid length "20" # Blows up 💣 ``` After: works Could just be my system though. @decentral1se what's it lookin like your end? Interestingly `pwgen -s "20" 1` works fine outside the script.
decentral1se was assigned by 3wordchant 2021-05-04 06:44:22 +00:00
3wordchant added 1 commit 2021-05-04 06:44:22 +00:00
Possible fix to invalid length "20"?
Some checks failed
continuous-integration/drone/pr Build is failing
Details
08d937104e
3wordchant commented 2021-05-04 08:46:25 +00:00
Author
Owner
Copy Link

Oh, looks like this issue was reported already – #149

Oh, looks like this issue was reported already – #149
decentral1se commented 2021-05-10 08:30:55 +00:00
Owner
Copy Link

Looks like latest Gitea upgrade borked this PR. Sorry. Doesn't seem to affect anything else as far as I can tell but you need to push again to the branch or do the close/re-open dance.

Looks like latest Gitea upgrade borked this PR. Sorry. Doesn't seem to affect anything else as far as I can tell but you need to push again to the branch or do the close/re-open dance.
decentral1se approved these changes 2021-05-10 08:34:40 +00:00
decentral1se left a comment
Owner

Perrfecccccttt :)

Perrfecccccttt :)
decentral1se commented 2021-05-10 08:35:06 +00:00
Owner
Copy Link

Just test this and it works on mine. I'll unfuck https://git.autonomic.zone/coop-cloud/abra/pulls/160#issuecomment-5633 and get this merged in.

Just test this and it works on mine. I'll unfuck https://git.autonomic.zone/coop-cloud/abra/pulls/160#issuecomment-5633 and get this merged in.
decentral1se closed this pull request 2021-05-10 08:35:06 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
breaking-change
Anything that breaks the existing API
bug
Something is not working
CI/CD
Anything to do with testing and infra
design
Anything to with UX of this tool
documentation
Documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
plugin
Related to the plugin architecture
question
More information is needed
secrets
Everything to do with docker secrets
shell-completion
To do with shell completion
versioning
All the things to do with versioning apps
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees decentral1se
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra-bash#160
No description provided.
Delete Branch "fix-pwgen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?