toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix(secret): Checks for enough arguments
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
p4u1 2025-02-10 15:32:57 +01:00 committed by decentral1se
parent 9069758969
commit 7b6ea76437
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cli/app/secret.go
View File

@ -49,11 +49,11 @@ var AppSecretGenerateCommand = &cobra.Command{
log.Fatal(err) log.Fatal(err)
} }
if len(args) == 1 && !generateAllSecrets { if len(args) <= 2 && !generateAllSecrets {
log.Fatal("missing arguments [secret]/[version] or '--all'") log.Fatal("missing arguments [secret]/[version] or '--all'")
} }
if len(args) > 1 && generateAllSecrets { if len(args) > 2 && generateAllSecrets {
log.Fatal("cannot use '[secret] [version]' and '--all' together") log.Fatal("cannot use '[secret] [version]' and '--all' together")
} }

5
tests/integration/app_secret.bats
View File

@ -41,6 +41,11 @@ teardown(){
run $ABRA app secret generate "$TEST_APP_DOMAIN" run $ABRA app secret generate "$TEST_APP_DOMAIN"
assert_failure assert_failure
assert_output --partial 'missing arguments'
run $ABRA app secret generate "$TEST_APP_DOMAIN" test_pass_one
assert_failure
assert_output --partial 'missing arguments'
run $ABRA app secret generate "$TEST_APP_DOMAIN" testSecret testVersion --all run $ABRA app secret generate "$TEST_APP_DOMAIN" testSecret testVersion --all
assert_failure assert_failure