toolshed/abra
4
2
Fork 18
Code Issues 25 Pull Requests 2 Packages Releases 41 Activity

feat(secrets): Reading from stdin and reproducible stdin #614

Merged
p4u1 merged 3 commits from p4u1/abra:insecrt-secret-from-stdin into main 2025-08-27 15:37:43 +00:00
Conversation 4 Commits 3 Files Changed 2 +85 -26
p4u1 commented 2025-08-25 13:19:29 +00:00
Member
Copy Link

I'm am scripting abra with ansible right now and ran into these issues.

Btw. is anyone interested in an ansible module for coopcloud?

I'm am scripting abra with ansible right now and ran into these issues. Btw. is anyone interested in an ansible module for coopcloud?
🚀 1
p4u1 added 2 commits 2025-08-25 13:19:30 +00:00
feat(secrets): Inserting secret data from stdin e92ff6e013 
This can be usefull for scripting and gives a lot of flexibility
feat(secrets): Sort list output
Some checks failed
continuous-integration/drone/pr Build is failing
Details
c9e293bde2 
This is usefull for scripting.
p4u1 changed title from insecrt-secret-from-stdin to feat(secrets): Reading from stdin and reproducible stdin 2025-08-25 13:20:07 +00:00
decentral1se reviewed 2025-08-25 21:03:36 +00:00
decentral1se left a comment
Owner
Copy Link

Solid 👏

(I'm curious about the Ansible role if it goes online, please share!)

Solid 👏 (I'm curious about the Ansible role if it goes online, please share!)
cli/app/secret.go
@ -192,0 +200,4 @@
data = args[3]
} else if len(args) == 3 {
if insertFromFile {
log.Fatal("can not insert from file and read from stdin")
decentral1se commented 2025-08-25 21:02:48 +00:00
Owner
Copy Link

It's a brave new world where we need to wrap all strings with i18n.G(...) so translators can keep up 🤸 You can basically use as a replacement for fmt.Sprintf. It does mean you end up using only log.Fatal and not log.Fatalf mostly. See the rest of the codebase for usage.

(I can sort this out after if you're moving fast and just wanna merge stuff)

It's a brave new world where we need to wrap all strings with `i18n.G(...)` so translators can keep up 🤸 You can basically use as a replacement for `fmt.Sprintf`. It does mean you end up using only `log.Fatal` and not `log.Fatalf` mostly. See the rest of the codebase for usage. (I can sort this out after if you're moving fast and just wanna merge stuff)
p4u1 commented 2025-08-25 21:28:17 +00:00
Author
Member
Copy Link

Ah, forgot about that, will update it tomorrow.
Btw. would it be possible to override the log.Fatal functions, so we can't forget the i18n.G call

Ah, forgot about that, will update it tomorrow. Btw. would it be possible to override the log.Fatal functions, so we can't forget the i18n.G call
decentral1se commented 2025-08-25 21:37:59 +00:00
Owner
Copy Link

Cool, sounds good. Yeh, that would be pretty amazing to wrap the logging functions 🤔 It'd probably be possible to wrap the logging functions and thread a string via i18n.G alright: https://git.coopcloud.tech/toolshed/abra/src/branch/main/pkg/log/log.go Maybe that's one for an additional PR which runs a mass sed -i ... on the entire codebase 🤣

Cool, sounds good. Yeh, that would be pretty amazing to wrap the logging functions 🤔 It'd probably be possible to wrap the logging functions and thread a string via `i18n.G` alright: https://git.coopcloud.tech/toolshed/abra/src/branch/main/pkg/log/log.go Maybe that's one for an additional PR which runs a mass `sed -i ...` on the entire codebase 🤣
decentral1se marked this conversation as resolved
decentral1se commented 2025-08-25 21:06:00 +00:00
Owner
Copy Link

CI suite failure seems related to my latest change in #612.

I thought I solved that... feel free to merge and I can loop back and fix things up afterwards.

CI suite failure seems related to my latest change in https://git.coopcloud.tech/toolshed/abra/pulls/612. I thought I solved that... feel free to merge and I can loop back and fix things up afterwards.
decentral1se added this to the Abra v0.11.x project 2025-08-25 21:11:01 +00:00
p4u1 added 1 commit 2025-08-27 11:29:49 +00:00
Merge remote-tracking branch 'upsteam/main' into insecrt-secret-from-stdin 474ab2de70
p4u1 force-pushed insecrt-secret-from-stdin from 474ab2de70 to 72fecf59ed 2025-08-27 13:19:44 +00:00 Compare
p4u1 force-pushed insecrt-secret-from-stdin from 72fecf59ed to 06b22914fc 2025-08-27 13:20:45 +00:00 Compare
p4u1 commented 2025-08-27 13:21:55 +00:00
Author
Member
Copy Link

@decentral1se @3wordchant made the rebase, can you have a look?

@decentral1se @3wordchant made the rebase, can you have a look?
🚀 1
decentral1se approved these changes 2025-08-27 14:00:07 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM ☀️

Thanks! Merge away 💣 ✅

LGTM ☀️ Thanks! Merge away 💣 ✅
decentral1se moved this to Done in Abra v0.11.x on 2025-08-27 14:00:32 +00:00
p4u1 merged commit 7c31e4dc45 into main 2025-08-27 15:37:43 +00:00
p4u1 deleted branch insecrt-secret-from-stdin 2025-08-27 15:37:43 +00:00
decentral1se removed this from the Abra v0.11.x project 2025-08-30 10:14:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno jmakdah2 kawaiipunk knoflook lambdabundesverband moritz p4u1 ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#614
No description provided.
Delete Branch "p4u1/abra:insecrt-secret-from-stdin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?