refactor!: do not set default timeout #612

decentral1se · 2025-08-25T09:40:27Z

decentral1se commented

2025-08-25 09:40:27 +00:00

No default timeout is now set.

You can still set it in the compose.yml:

- "coop-cloud.${STACK_NAME}.timeout=${TIMEOUT:-120}"

Or by setting it in your .env: TIMEOUT=120.

Setting the default in the label should now be strongly discouraged because it imposes a default timeout on every operator which might not fit their situation. We need to remove those in recipes and make new releases. The "new way" is to only set the TIMEOUT=... in your .env if you need it.

I spent some time refactoring the unit test resources, they make more sense now. We have unit/integration testing for this change. I found a bunch more strings to add i18n.G to down in the depths of some upstream copy/pasta module.

See https://git.coopcloud.tech/toolshed/abra/issues/596. No default timeout is now set. You can still set it in the `compose.yml`: ```yaml - "coop-cloud.${STACK_NAME}.timeout=${TIMEOUT:-120}" ``` Or by setting it in your `.env`: `TIMEOUT=120`. Setting the default in the label should now be strongly discouraged because it imposes a default timeout on every operator which might not fit their situation. We need to remove those in recipes and make new releases. The "new way" is to *only* set the `TIMEOUT=...` in your `.env` if you need it. I spent some time refactoring the unit test resources, they make more sense now. We have unit/integration testing for this change. I found a bunch more strings to add `i18n.G` to down in the depths of some upstream copy/pasta module.

🎉 1

decentral1se added 4 commits 2025-08-25 09:40:27 +00:00

chore: restructure unit testing resources 6ccef5aa5d

test(integration): ensure timeout handling 6ef569295a

test(unit): ensure timeout handling ac3a234475

refactor: timeout only when TIMEOUT=... in .env

continuous-integration/drone/push Build is failing

Details

continuous-integration/drone/pr Build is failing

Details

a595886fba

See #596

Quite some `i18n.G` additions along the way!

decentral1se added 1 commit 2025-08-25 09:47:37 +00:00

fixup! chore: restructure unit testing resources

continuous-integration/drone/push Build is failing

Details

e47d1f615e

decentral1se changed title from ~~refactor: use timeout only when `TIMEOUT=...` specified in `.env`~~ to refactor!: do not set default timeout

2025-08-25 09:48:33 +00:00

decentral1se force-pushed refactor/596 from e47d1f615e to 6a52575ae0

2025-08-25 09:49:28 +00:00

Compare

decentral1se added 1 commit 2025-08-25 09:55:49 +00:00

test: pass ABRA_DIR to unit test on CI

continuous-integration/drone/push Build is passing

Details

f39eab8f1e

decentral1se merged commit f39eab8f1e into main

2025-08-25 10:05:52 +00:00

decentral1se deleted branch refactor/596