toolshed/abra
4
3
Fork 18
Code Issues 34 Pull Requests 4 Packages Releases 42 Activity

Should --force allow redeploying a chaos-deployed instance without --chaos? #646

New Issue
Closed
opened 2025-09-04 16:07:05 +00:00 by 3wordchant · 6 comments
3wordchant commented 2025-09-04 16:07:05 +00:00
Owner
Copy Link

This integration test fails after !644, implying that the following should work:

abra app deploy foo.bar.com --chaos
abra app deploy foo.bar.com --force

Personally I kinda still stand by #554 comment 26664, "I think bailing on non-chaos deploy is the least-wrong thing to do here"

[This integration test](https://git.coopcloud.tech/toolshed/abra/src/branch/main/tests/integration/app_deploy.bats#L229-L231) fails after !644, implying that the following should work: ```bash abra app deploy foo.bar.com --chaos abra app deploy foo.bar.com --force ``` Personally I kinda still stand by [#554 comment 26664](https://git.coopcloud.tech/toolshed/abra/issues/554#issuecomment-26664), "I think bailing on non-chaos deploy is the least-wrong thing to do here"
3wordchant added the
question
 label 2025-09-04 16:07:05 +00:00
3wordchant commented 2025-09-04 16:11:19 +00:00
Author
Owner
Copy Link

Ah and this test implies that abra app deploy foo.bar.com <commit hash> should work without --chaos too 🤔

Ah and [this test](https://git.coopcloud.tech/toolshed/abra/src/branch/main/tests/integration/app_deploy_env_version.bats#L58-L59) implies that `abra app deploy foo.bar.com <commit hash>` should work without `--chaos` too 🤔
decentral1se commented 2025-09-04 17:21:47 +00:00
Owner
Copy Link

Oh, great spot.

Personally I kinda still stand by #554 (comment), "I think bailing on non-chaos deploy is the least-wrong thing to do here"

I'm for that as well! Passing -Cf seems more logical to me.

We also had a similar feeling situation with trying to name --latest on abra app deploy and chaining --force --latest seemed quite consistent.

Ah and this test implies that abra app deploy foo.bar.com should work without --chaos too 🤔

Seems a bit tedious but I'm for also mandating -C here just for simplicity / consistency sake.

Oh, great spot. > Personally I kinda still stand by https://git.coopcloud.tech/toolshed/abra/issues/554#issuecomment-26664, "I think bailing on non-chaos deploy is the least-wrong thing to do here" I'm for that as well! Passing `-Cf` seems more logical to me. We also had a similar feeling situation with trying to name `--latest` on `abra app deploy` and chaining `--force --latest` seemed quite consistent. > Ah and this test implies that abra app deploy foo.bar.com <commit hash> should work without --chaos too 🤔 Seems a bit tedious but I'm for also mandating `-C` here just for simplicity / consistency sake.
👍 1
3wordchant commented 2025-09-04 17:52:34 +00:00
Author
Owner
Copy Link

OK roger that I'll update the tests 🫡

OK roger that I'll update the tests 🫡
🎉 1
decentral1se added this to the Abra v0.11.x project 2025-09-04 20:55:57 +00:00
decentral1se moved this to In Progress in Abra v0.11.x on 2025-09-04 20:56:56 +00:00
3wordchant was assigned by decentral1se 2025-09-08 14:46:53 +00:00
3wordchant commented 2025-09-08 18:53:35 +00:00
Author
Owner
Copy Link

Tales from Matrix:

  ✗ hash deploy then force deploy [9387]
  ...
   output : FATA cannot use [version] and --chaos together

after PR !644 now there is no way to deploy a specific hash 😕
well, there is - manually checking out that commit then --chaos. but no single command any more
maybe there's an argument that --chaos shouldn't be required if someone specifies the hash on the CLI?
—3wordchant

fack, maybe we're back to "--chaos implied by deploying commit hash" as a log.Warn and then set internal.Chaos = true when deploying specific hash and run away?
—decentral1se

yeah this sounds fine actually
—3wordchant

Tales from Matrix: ``` ✗ hash deploy then force deploy [9387] ... output : FATA cannot use [version] and --chaos together ``` > after PR !644 now there is no way to deploy a specific hash 😕 > well, there is - manually checking out that commit then `--chaos`. but no single command any more > maybe there's an argument that `--chaos` shouldn't be required if someone specifies the hash on the CLI? > —3wordchant > fack, maybe we're back to "`--chaos` implied by deploying commit hash" as a log.Warn and then set `internal.Chaos = true` when deploying specific hash and run away? > —decentral1se > yeah this sounds fine actually > —3wordchant
3wordchant commented 2025-09-09 02:22:49 +00:00
Author
Owner
Copy Link
➜ ./abra app deploy ghost-demo 
WARN version '298401b2' appears to be a chaos commit, but --chaos/-C was not provided
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃                  NEW DEPLOY OVERVIEW                  ┃
┃                                                       ┃
┃ DOMAIN                ghost.swarm-test.autonomic.zone ┃
┃ RECIPE                ghost                           ┃
┃ SERVER                swarm-test.autonomic.zone       ┃
┃ CONFIG                compose.yml                     ┃
┃                                                       ┃
┃ CURRENT DEPLOYMENT    N/A                             ┃
┃ ENV VERSION           298401b2                        ┃
┃ NEW DEPLOYMENT        298401b2                        ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
...
➜ ./abra app ls -S -s swarm-test.autonomic.zone
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃  RECIPE   ┃              DOMAIN               ┃          SERVER           ┃  STATUS  ┃  CHAOS  ┃   VERSION    ┃   UPGRADE    ┃ AUTOUPDATE ┃
┣━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━╋━━━━━━━━━╋━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━╋━━━━━━━━━━━━┫
┃ ghost     ┃ ghost.swarm-test.autonomic.zone   ┃ swarm-test.autonomic.zone ┃ deployed ┃ true    ┃ 298401b2     ┃ latest       ┃ false      ┃
...
``` ➜ ./abra app deploy ghost-demo WARN version '298401b2' appears to be a chaos commit, but --chaos/-C was not provided ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓ ┃ NEW DEPLOY OVERVIEW ┃ ┃ ┃ ┃ DOMAIN ghost.swarm-test.autonomic.zone ┃ ┃ RECIPE ghost ┃ ┃ SERVER swarm-test.autonomic.zone ┃ ┃ CONFIG compose.yml ┃ ┃ ┃ ┃ CURRENT DEPLOYMENT N/A ┃ ┃ ENV VERSION 298401b2 ┃ ┃ NEW DEPLOYMENT 298401b2 ┃ ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ ... ➜ ./abra app ls -S -s swarm-test.autonomic.zone ┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ RECIPE ┃ DOMAIN ┃ SERVER ┃ STATUS ┃ CHAOS ┃ VERSION ┃ UPGRADE ┃ AUTOUPDATE ┃ ┣━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━╋━━━━━━━━━╋━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━╋━━━━━━━━━━━━┫ ┃ ghost ┃ ghost.swarm-test.autonomic.zone ┃ swarm-test.autonomic.zone ┃ deployed ┃ true ┃ 298401b2 ┃ latest ┃ false ┃ ... ```
decentral1se commented 2025-09-09 07:43:32 +00:00
Owner
Copy Link

@3wordchant oh yeh, great! this seems good? that may be the winner for now then? 🤸 And then no tests chaos to fix? Maybe one to add to ensure that WARN message appears but otherwise, I think we could run away with this fix and then re-close #554 and call it a day.

@3wordchant oh yeh, great! this seems good? that may be the winner for now then? 🤸 And then no tests chaos to fix? Maybe one to add to ensure that `WARN` message appears but otherwise, I think we could run away with this fix and then re-close https://git.coopcloud.tech/toolshed/abra/issues/554 and call it a day.
decentral1se moved this to Done in Abra v0.11.x on 2025-09-09 20:24:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
question
Milestone
No items
No Milestone
Projects
Clear projects
No project Abra v0.11.x
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees 3wordchant
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#646
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?