toolshed/abra
4
3
Fork 19
Code Issues 39 Pull Requests 4 Packages Releases 42 Activity

Bail on non-chaos deploy if the env version is a hash #644

Merged
decentral1se merged 3 commits from fix/3wc/554 into main 2025-09-04 08:14:08 +00:00
Conversation 2 Commits 3 Files Changed 4 +59 -34
3wordchant commented 2025-09-03 18:20:09 +00:00
Owner
Copy Link

Fixes #554

NB I also ran into a problem where _ensure_env_version was unconditionally setting versions to $1 because of the use of single quotes – running the full suite now, wouldn't be surprised if fixing that explodes something.

Fixes #554 NB I also ran into a problem where `_ensure_env_version` was unconditionally setting versions to `$1` because of the use of single quotes – running the full suite now, wouldn't be surprised if fixing that explodes something.
3wordchant added 3 commits 2025-09-03 18:20:09 +00:00
Error out if env version is chaos-y and --chaos not provided
Some checks failed
continuous-integration/drone/push Build is failing
Details
446cf796b3 
Re #554
Whoops, gettext
All checks were successful
continuous-integration/drone/push Build is passing
Details
7835525dbc
Add test to make sure non-chaos hash deploy fails..
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
4d7609d202 
..and make sure _ensure_env_version passes through variable correctly.
3wordchant force-pushed fix/3wc/554 from 4d7609d202 to 7835525dbc 2025-09-03 18:24:26 +00:00 Compare
3wordchant added 1 commit 2025-09-03 18:24:55 +00:00
Add test to make sure non-chaos hash deploy fails..
All checks were successful
continuous-integration/drone/push Build is passing
Details
6d706955a7 
..and make sure _ensure_env_version passes through variable correctly.
3wordchant force-pushed fix/3wc/554 from 6d706955a7 to 0bb6d9609c 2025-09-03 18:25:48 +00:00 Compare
decentral1se approved these changes 2025-09-04 08:14:02 +00:00
decentral1se left a comment
Owner
Copy Link

Nice one!

Nice one!
decentral1se merged commit 0bb6d9609c into main 2025-09-04 08:14:08 +00:00
decentral1se deleted branch fix/3wc/554 2025-09-04 08:14:09 +00:00
decentral1se commented 2025-09-04 15:17:33 +00:00
Owner
Copy Link

@3wordchant oh yeh can I nag you to adopt the https://www.conventionalcommits.org/en/v1.0.0/ for future commit messages? this then gets picked up by our goreleaser automation and prepares a changelog which gives more of an overview for driveby scans of what happened between versions because it's easier to filter through. e.g. i go and pull out all the random commits and include only the fix/feat/refactor (if breaking) in the listing. thanks 🙏

@3wordchant oh yeh can I nag you to adopt the https://www.conventionalcommits.org/en/v1.0.0/ for future commit messages? this then gets picked up by our goreleaser automation and prepares a changelog which gives more of an overview for driveby scans of what happened between versions because it's easier to filter through. e.g. i go and pull out all the random commits and include only the `fix`/`feat`/`refactor` (if breaking) in the listing. thanks 🙏
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#644
No description provided.
Delete Branch "fix/3wc/554"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?