Clearer error messages for non-generated secrets #665

New Issue

cyrnel · 2025-09-14T14:57:18Z

cyrnel commented

2025-09-14 14:57:18 +00:00

Hello, I'm working on the renovate recipe here: coop-cloud/renovate#4

Renovate has no generated secrets, but the recipe user does need to set a token for accessing their git forge. I've set these in .env.sample and added the # generated=false comment as mentioned here: https://docs.coopcloud.tech/maintainers/handbook/#how-do-i-skip-secret-generation-for-a-specific-secret

When running abra app new renovate, it will print the message "renovate requires secret generation before deploying", even though those secrets have generate=false comments in .env.sample.
- Instead, Abra should say something like "renovate requires you to set some secrets before deploying, run abra app secret insert ...". It should print both messages if there's a mixture of generated and non-generated secrets.
When enabling a new secret via abra app config and running abra app deploy, it will print the message "secret not generated: github_token".
- Instead, the code should check if the secret is a generated secret or not, and change the error message accordingly. Also, ideally this error message should tell the user which abra app secret command to run to fix it.

Hello, I'm working on the renovate recipe here: https://git.coopcloud.tech/coop-cloud/renovate/pulls/4 Renovate has no generated secrets, but the recipe user does need to set a token for accessing their git forge. I've set these in .env.sample and added the `# generated=false` comment as mentioned here: https://docs.coopcloud.tech/maintainers/handbook/#how-do-i-skip-secret-generation-for-a-specific-secret 1. When running `abra app new renovate`, it will print the message "[renovate requires secret generation before deploying](https://git.coopcloud.tech/toolshed/abra/src/commit/09176801e169a2836cde1ab3610e57c6a2eb968b/cli/app/new.go#L195)", even though those secrets have `generate=false` comments in .env.sample. - Instead, Abra should say something like "renovate requires you to set some secrets before deploying, run `abra app secret insert ...`". It should print both messages if there's a mixture of generated and non-generated secrets. 2. When enabling a new secret via `abra app config` and running `abra app deploy`, it will print the message "[secret not generated: github_token](https://git.coopcloud.tech/toolshed/abra/src/commit/f53ba48efa6f37c5a61e86f829f87db9f0fa8d78/cli/app/deploy.go#L310)". - Instead, the code should check if the secret is a generated secret or not, and change the error message accordingly. Also, ideally this error message should tell the user which `abra app secret` command to run to fix it.

👍 2

decentral1se commented

2025-09-15 07:41:18 +00:00

Excellent report, thanks! Yes, I believe we have a boolean on the secret struct to indicate if it's a "no generate" or not and can adjust the messages accordingly. Thanks for testing this new feature out so fast 🔆

decentral1se added the

bug

label 2025-09-15 07:46:02 +00:00

decentral1se added this to the Abra "next" project 2025-09-15 07:46:23 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#665