fix: improved handling for #generate=false #673

decentral1se · 2025-09-29T08:34:50Z

decentral1se commented

2025-09-29 08:34:50 +00:00

Notes on this one. @cyrnel your feedback is very welcome!

I did not add a "this is how you insert the secret" message as proposed in #665 (comment) because in the case of rauthy, it is not a simple "just insert something", you need to run a specific command from the abra.sh in https://git.coopcloud.tech/coop-cloud/rauthy/src/branch/main/abra.sh. Most cases of insertion and #generate=false require some special handling, so I didn't want to give false advise and just limited it to "you need to insert something"
#665 (comment) was a bug in the output and not in the actual generation. The logic wasn't smart enough to understand if --secrets was passed or not. This is now tested and covered.

See https://git.coopcloud.tech/toolshed/abra/issues/665 Notes on this one. @cyrnel your feedback is very welcome! * I did not add a "this is how you insert the secret" message as proposed in https://git.coopcloud.tech/toolshed/abra/issues/665#issue-5067 because in the case of rauthy, it is not a simple "just insert something", you need to run a specific command from the `abra.sh` in https://git.coopcloud.tech/coop-cloud/rauthy/src/branch/main/abra.sh. Most cases of insertion and `#generate=false` require some special handling, so I didn't want to give false advise and just limited it to "you need to insert something" * https://git.coopcloud.tech/toolshed/abra/issues/665#issuecomment-27221 was a bug in the output and not in the actual generation. The logic wasn't smart enough to understand if `--secrets` was passed or not. This is now tested and covered.

❤️ 1

decentral1se added 6 commits 2025-09-29 08:34:50 +00:00

docs: better wording 81b96fc7b1

fix: nuance of generate=false for app new 5c892b1d6a

fix: nuance of generate=false for app deploy dee2d9d104

fix: collect local name also f468bc7443

test: further generate=false secre tests d50d68d95a

chore: make i18n

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details