toolshed/abra
4
4
Fork 23
Code Issues 82 Pull Requests 13 Packages Releases 45 Activity

Adding server manually without server add creates unclear error on deploy #675

New Issue
Closed
opened 2025-09-30 18:56:31 +00:00 by decentral1se · 3 comments
decentral1se commented 2025-09-30 18:56:31 +00:00
Owner
Copy Link
Copy Source

If you are syncing in folders or adding them manually but you don't abra server add <server>, then the docker client doesn't get created and it appears like abra ignores it. When you deploy, it shows: FATA unknown server, run "abra server add <server>" which does fix it.

However, this error kind of pops up out of nowhere on a deploy. Also, you think you've added the server correctly. So, we could probably detect if there is a client configured correctly or not and adjust the "unknown server" part to "missing client for server".

/cc @kolaente

If you are syncing in folders or adding them manually but you don't `abra server add <server>`, then the docker client doesn't get created and it appears like `abra` ignores it. When you deploy, it shows: `FATA unknown server, run "abra server add <server>"` which does fix it. However, this error kind of pops up out of nowhere on a deploy. Also, you think you've added the server correctly. So, we could probably detect if there is a client configured correctly or not and adjust the "unknown server" part to "missing client for server". /cc @kolaente
👍 1
decentral1se added the enhancement label 2025-09-30 18:56:31 +00:00
decentral1se changed title from Adding server manually without `server add` ignores server to Adding server manually without `server add` creates unclear error on deploy 2025-09-30 19:00:08 +00:00
decentral1se added this to the Abra v0.12 project 2025-09-30 19:03:35 +00:00
decentral1se moved this to Prioritised in Abra v0.12 on 2025-09-30 19:03:42 +00:00
decentral1se moved this to In Progress in Abra v0.12 on 2025-10-01 09:27:49 +00:00
decentral1se started working 2025-10-01 09:28:02 +00:00
decentral1se worked for 22 minutes 2025-10-01 09:50:58 +00:00
decentral1se moved this to Done in Abra v0.12 on 2025-10-01 09:51:09 +00:00
simon commented 2025-10-01 11:25:00 +00:00
Member
Copy Link
Copy Source

ty for improving the handling!

just had a quick thought, how about not throwing that error but prompting whether abra should try to add the specific server?
e.g.
"server missing context, proceed to try running "abra server add %s" (Y/n)?
and then just run that command?

ty for improving the handling! just had a quick thought, how about not throwing that error but prompting whether abra should try to add the specific server? e.g. "server missing context, proceed to try running \"abra server add %s\" (Y/n)? and then just run that command?
decentral1se commented 2025-10-01 13:13:42 +00:00
Author
Owner
Copy Link
Copy Source

@simon thanks for the feedback! I thought about it but since the server name is customisable via ~/.ssh/config and these names might change while syncing across work stations (the reason why this bug happens in the first place), we might end up in a situation where we're recommending a server name which isn't valid. Which is still a problem with this new handling but it's less work than doing an interactive prompt, handling --no-input and further handling the failure when the server is wrong... 🙃 I have a feeling less is more in this case...

@simon thanks for the feedback! I thought about it but since the server name is customisable via `~/.ssh/config` and these names might change while syncing across work stations (the reason why this bug happens in the first place), we might end up in a situation where we're recommending a server name which isn't valid. Which is still a problem with this new handling but it's less work than doing an interactive prompt, handling `--no-input` and further handling the failure when the server is wrong... 🙃 I have a feeling less is more in this case...
👍 1
decentral1se commented 2025-11-04 13:20:02 +00:00
Author
Owner
Copy Link
Copy Source

4b688825e0

https://git.coopcloud.tech/toolshed/abra/commit/4b688825e0b8457f12e62e7f88968aa7c52e752e
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 build
go build related issues
 ci/cd
Building things with CI/CD
 critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
 design
UI/UX
 documentation
Documenting all the things
 duplicate
This issue or pull request already exists
 easy-first-issue
Something for new people to get stuck into. We hope it's easy!
 enhancement
New feature
 help wanted
Need some help
 i10n
Everything to do with localisation
 i18n
Everything to do with internationalisation
 installer
Everything to do with the install script.
 invalid
Something is wrong
 question
More information is needed
 release
Release management
 release-candidate
Related to the new release candidate
 security
Security related
 tech-debt
test
Unit/integration testing
 wontfix
This won't be fixed
No labels enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Abra v0.12
Done
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm BornDeleuze Brooke carla cas (Cassowary) coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) iexos jade (Jade Ambrose) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) moosemower moritz notplants oxaliq (sorrel) p4u1 pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) renovate-bot (Comrade Renovate Bot) ripclap simon sixsmith (Sixsmith) stevensting trav (Trav Fryer) val (val (he/him)) yksflip
No Assignees
2 Participants
Notifications
Total Time Spent: 22 minutes
decentral1se
22 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#675