Adding server manually without server add creates unclear error on deploy
#675
No Assignees
Notifications
Total Time Spent: 22 minutes
Due Date
decentral1se
22 minutes
No due date set.
Dependencies
No dependencies set.
Reference: toolshed/abra#675
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
If you are syncing in folders or adding them manually but you don't
abra server add <server>, then the docker client doesn't get created and it appears likeabraignores it. When you deploy, it shows:FATA unknown server, run "abra server add <server>"which does fix it.However, this error kind of pops up out of nowhere on a deploy. Also, you think you've added the server correctly. So, we could probably detect if there is a client configured correctly or not and adjust the "unknown server" part to "missing client for server".
/cc @kolaente
Adding server manually without `server add` ignores serverto Adding server manually without `server add` creates unclear error on deployty for improving the handling!
just had a quick thought, how about not throwing that error but prompting whether abra should try to add the specific server?
e.g.
"server missing context, proceed to try running "abra server add %s" (Y/n)?
and then just run that command?
@simon thanks for the feedback! I thought about it but since the server name is customisable via
~/.ssh/configand these names might change while syncing across work stations (the reason why this bug happens in the first place), we might end up in a situation where we're recommending a server name which isn't valid. Which is still a problem with this new handling but it's less work than doing an interactive prompt, handling--no-inputand further handling the failure when the server is wrong... 🙃 I have a feeling less is more in this case...