abra recipe release: support maintainer pull request review workflow
#806
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow up of coop-cloud/traefik#98.
If you run
abra recipe releaseit automatically bumps the labels and commits/pushes the tag. However, for a maintainer recipe pull request review workflow ™️, you want to push your commit from a branch and open a pull request.What happened in coop-cloud/traefik#98 is that the tag was already pushed and released on the catalogue but the pull request was not reviewed 🙃 As mentioned in coop-cloud/traefik#98 (comment), we need some proposals for how
abra recipe releasecan adapt to the collective use-case and not exclusively work for the lone maintainer.Proposals welcome!
Merging changes and releasing are two very different things. The new flow requires you to commit your changes before making a release. I don't know how this commit was created but it should not possible with v0.13
abra recipe release. @moritzRight now you might contribute all your changes via PR. Then someone has to do the release on main branch. But for actually publishing via PR you would need it to create a tag which I guess is only be possible via CI?