toolshed/abra
4
4
Fork 23
Code Issues 75 Pull Requests 8 Packages Releases 45 Activity

Use docker login credentials from host #855

Merged
decentral1se merged 2 commits from ineiti/abra:add_docker_login into main 2026-06-16 17:41:01 +00:00
Conversation 6 Commits 2 Files Changed 5 +630 -351
ineiti commented 2026-05-29 08:44:26 +00:00
Contributor
Copy Link

I had a lot of failures for pulling the docker images lately,
so I was looking for a way to connect using docker login.
This PR sends the docker login credentials from the host to
the swarm server.

I had a lot of failures for pulling the docker images lately, so I was looking for a way to connect using docker login. This PR sends the docker login credentials from the host to the swarm server.
❤️ 1
ineiti added 1 commit 2026-05-29 08:44:28 +00:00
Use docker login credentials from host
Some checks failed
continuous-integration/drone/pr Build is failing
Details
81f4e6687e 
I had a lot of failures for pulling the docker images lately,
so I was looking for a way to connect using docker login.
This PR sends the docker login credentials from the host to
the swarm server.
ineiti force-pushed add_docker_login from 81f4e6687e to 12d4252acb 2026-05-29 13:28:00 +00:00 Compare
p4u1 commented 2026-06-05 07:43:56 +00:00
Owner
Copy Link

The actual change looks good to me. I just wonder if we should put this behind a flag. What do you others think?

The actual change looks good to me. I just wonder if we should put this behind a flag. What do you others think?
decentral1se commented 2026-06-10 09:43:30 +00:00
Owner
Copy Link

@ineiti LGTM! thanks! Yeh, following what @p4u1 said, is there any impact on people who haven't done a docker login? Then it is not a breaking change and we can just merge this, right? If you could try to smoke out any issues with this, it would be appreciated! We can try to merge it then.

@ineiti LGTM! thanks! Yeh, following what @p4u1 said, is there any impact on people who haven't done a `docker login`? Then it is not a breaking change and we can just merge this, right? If you could try to smoke out any issues with this, it would be appreciated! We can try to merge it then.
decentral1se added this to the Abra "next" project 2026-06-10 09:43:41 +00:00
decentral1se moved this to In Progress in Abra "next" on 2026-06-10 09:43:46 +00:00
ineiti commented 2026-06-13 19:43:21 +00:00
Author
Contributor
Copy Link

OK, confirmed that updating lasuite-docs with an empty docker login, I get something like

WARN image ghcr.io/docspecio/api:3.0.2 could not be accessed on a registry to record

which disappears once I login to ghcr.io.

OK, confirmed that updating lasuite-docs with an empty docker login, I get something like ```bash WARN image ghcr.io/docspecio/api:3.0.2 could not be accessed on a registry to record ``` which disappears once I login to ghcr.io.
❤️ 1
ineiti force-pushed add_docker_login from 12d4252acb to bf99cea640 2026-06-13 19:52:42 +00:00 Compare
ineiti commented 2026-06-13 19:53:33 +00:00
Author
Contributor
Copy Link

@decentral1se also rebased on latest main. Btw: there seems to be a make i18n missing lately. it changes a lot of lines, so I didn't run it for this PR. Or should I?

@decentral1se also rebased on latest main. Btw: there seems to be a `make i18n` missing lately. it changes a lot of lines, so I didn't run it for this PR. Or should I?
decentral1se commented 2026-06-14 09:09:14 +00:00
Owner
Copy Link

@ineiti yes, make i18n is noisy but usually required. If you can do that, then we can merge. Thanks!

@ineiti yes, `make i18n` is noisy but usually required. If you can do that, then we can merge. Thanks!
👍 1
ineiti added 1 commit 2026-06-14 15:57:25 +00:00
Running i18n 8f09ae2525
decentral1se approved these changes 2026-06-16 17:40:52 +00:00
decentral1se left a comment
Owner
Copy Link

💟

💟
decentral1se merged commit 427ec22cab into main 2026-06-16 17:41:01 +00:00
decentral1se deleted branch add_docker_login 2026-06-16 17:41:02 +00:00
decentral1se moved this to Done in Abra "next" on 2026-06-16 17:41:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
tech-debt
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Abra "next"
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 amras Apfelwurm BornDeleuze Brooke carla cas coopcloud cyrnel decentral1se dede fauno iexos jade jjsfunhouse jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moosemower moritz notplants oxaliq p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith stevensting trav val yksflip
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#855
No description provided.
Delete Branch "ineiti/abra:add_docker_login"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?