Use docker login credentials from host #855

2026-05-29T08:44:26Z

ineiti commented

2026-05-29 08:44:26 +00:00

I had a lot of failures for pulling the docker images lately,
so I was looking for a way to connect using docker login.
This PR sends the docker login credentials from the host to
the swarm server.

I had a lot of failures for pulling the docker images lately, so I was looking for a way to connect using docker login. This PR sends the docker login credentials from the host to the swarm server.

❤️ 1

ineiti added 1 commit 2026-05-29 08:44:28 +00:00

Use docker login credentials from host

continuous-integration/drone/pr Build is failing

Details

81f4e6687e

I had a lot of failures for pulling the docker images lately,
so I was looking for a way to connect using docker login.
This PR sends the docker login credentials from the host to
the swarm server.

ineiti force-pushed add_docker_login from 81f4e6687e to 12d4252acb

2026-05-29 13:28:00 +00:00

Compare

p4u1 commented

2026-06-05 07:43:56 +00:00

The actual change looks good to me. I just wonder if we should put this behind a flag. What do you others think?

decentral1se commented

2026-06-10 09:43:30 +00:00

@ineiti LGTM! thanks! Yeh, following what @p4u1 said, is there any impact on people who haven't done a docker login? Then it is not a breaking change and we can just merge this, right? If you could try to smoke out any issues with this, it would be appreciated! We can try to merge it then.

@ineiti LGTM! thanks! Yeh, following what @p4u1 said, is there any impact on people who haven't done a `docker login`? Then it is not a breaking change and we can just merge this, right? If you could try to smoke out any issues with this, it would be appreciated! We can try to merge it then.

decentral1se added this to the Abra "next" project 2026-06-10 09:43:41 +00:00

decentral1se moved this to In Progress in Abra "next" on 2026-06-10 09:43:46 +00:00

ineiti commented

2026-06-13 19:43:21 +00:00

OK, confirmed that updating lasuite-docs with an empty docker login, I get something like

WARN image ghcr.io/docspecio/api:3.0.2 could not be accessed on a registry to record

which disappears once I login to ghcr.io.

OK, confirmed that updating lasuite-docs with an empty docker login, I get something like ```bash WARN image ghcr.io/docspecio/api:3.0.2 could not be accessed on a registry to record ``` which disappears once I login to ghcr.io.

❤️ 1

ineiti force-pushed add_docker_login from 12d4252acb to bf99cea640

2026-06-13 19:52:42 +00:00

Compare

ineiti commented

2026-06-13 19:53:33 +00:00

@decentral1se also rebased on latest main. Btw: there seems to be a make i18n missing lately. it changes a lot of lines, so I didn't run it for this PR. Or should I?

@decentral1se also rebased on latest main. Btw: there seems to be a `make i18n` missing lately. it changes a lot of lines, so I didn't run it for this PR. Or should I?

decentral1se commented

2026-06-14 09:09:14 +00:00

@ineiti yes, make i18n is noisy but usually required. If you can do that, then we can merge. Thanks!

@ineiti yes, `make i18n` is noisy but usually required. If you can do that, then we can merge. Thanks!

👍 1

ineiti added 1 commit 2026-06-14 15:57:25 +00:00

Running i18n 8f09ae2525

decentral1se approved these changes 2026-06-16 17:40:52 +00:00

decentral1se left a comment

💟

decentral1se merged commit 427ec22cab into main

2026-06-16 17:41:01 +00:00