fix: add compose.yml before commiting with recipe release; reset parts of tag according to semver when releasing #106

2021-10-05T14:07:17Z

knoflook commented

2021-10-05 14:07:17 +00:00

some small changes here and there. Now abra shouldn't freak out when tagging and it adds compose.yml before commiting it!

decentral1se reviewed

2021-10-05 14:13:15 +00:00

cli/recipe/release.go Outdated

						
				@@ -118,6 +119,12 @@ or a rollback of an app.

								}

								survey.AskOne(prompt, &CommitMessage)

							}

							_, err = commitWorktree.Add("compose.yml")

decentral1se commented

2021-10-05 14:13:04 +00:00

You might want to glob for compose.**.yml here since the recipes can have multiple compose files?

You might want to glob for `compose.**.yml` here since the recipes can have multiple compose files?

knoflook commented

2021-10-05 14:33:14 +00:00

yess, I'm also a bit worried about annotated vs unannotated tags because the stupid git library allows listing either one or the other and uses different return formats for them (https://pkg.go.dev/github.com/go-git/go-git/v5#Repository.TagObjects and https://pkg.go.dev/github.com/go-git/go-git/v5#Repository.Tags)

knoflook marked this conversation as resolved

knoflook force-pushed recipe-release from f2842882d6 to 2b3870d61a

2021-10-05 14:34:04 +00:00

Compare

knoflook force-pushed recipe-release from 2b3870d61a to 3f91989511

2021-10-05 14:35:28 +00:00

Compare

knoflook force-pushed recipe-release from 3f91989511 to 1cb5e3509d

2021-10-05 14:36:21 +00:00

Compare

decentral1se merged commit 1cb5e3509d into main

2021-10-05 14:58:37 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#106

Allow edits from maintainers