toolshed/abra
4
3
Fork 21
Code Issues 40 Pull Requests 4 Packages Releases 42 Activity

fix: filtering requires case-by-case handling #173

Closed
decentral1se wants to merge 0 commits from filtering-fixes into main
pull from: filtering-fixes
merge into: toolshed:main
Conversation 1 Commits - Files Changed - +35 -10
decentral1se commented 2022-03-30 14:15:06 +00:00
Owner
Copy Link

Unborking latest as a result of coop-cloud/abra#169.

Part 1. what I didn't realised or what didn't come up in my testing is that docker behaves differently for --filter ... on different commands 😱 See https://github.com/moby/moby/issues/32985.

Part 2. not every filter requires the service name to be appended.

Unborking latest as a result of https://git.coopcloud.tech/coop-cloud/abra/pulls/169. Part 1. what I didn't realised or what didn't come up in my testing is that docker behaves differently for `--filter ...` on different commands 😱 See https://github.com/moby/moby/issues/32985. Part 2. not every filter requires the service name to be appended.
decentral1se force-pushed filtering-fixes from 82a8273bfa to fe309af5ed 2022-03-30 14:22:12 +00:00 Compare
decentral1se force-pushed filtering-fixes from fe309af5ed to 323f4467c8 2022-03-30 14:27:21 +00:00 Compare
decentral1se commented 2022-03-30 14:27:37 +00:00
Author
Owner
Copy Link

323f4467c8

323f4467c8599c438b8209119ed303aaebf91915
decentral1se closed this pull request 2022-03-30 14:28:03 +00:00
decentral1se deleted branch filtering-fixes 2022-03-30 14:28:34 +00:00
Some checks reported errors
continuous-integration/drone/pr Build was killed
Details
continuous-integration/drone/push Build was killed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#173
No description provided.
Delete Branch "filtering-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?