toolshed/abra
4
4
Fork 23
Code Issues 82 Pull Requests 11 Packages Releases 45 Activity

fix: switch back to replacing <recipe>.example.com #228

Merged
3wordchant merged 2 commits from unsmart-templating into main 2022-11-24 17:34:01 +00:00
Conversation 3 Commits 2 Files Changed 1
+4 -14
3wordchant commented 2022-11-14 15:49:58 +00:00
Owner
Copy Link
Copy Source

Fixes coop-cloud/organising#355

Test plan:

  1. abra app new dashy
  2. abra app config <domain>

Domain name filled in correctly!

Fixes coop-cloud/organising#355 Test plan: 1. `abra app new dashy` 2. `abra app config <domain>` Domain name filled in correctly!
3wordchant added 1 commit 2022-11-14 15:49:59 +00:00
fix: switch back to replacing <recipe>.example.com
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
9927bbbea2 
Fixes #355
decentral1se reviewed 2022-11-14 16:04:23 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

💯

TODO for me is to fix up this then:

grep -iR "\{ \.Domain \}" .
./hometown/.env.sample:DOMAIN={{ .Domain }}
./amusewiki/.env.sample:DOMAIN={{ .Domain }}
./rsshub/.env.sample:DOMAIN={{ .Domain }}
./traefik/.env.sample:DOMAIN={{ .Domain }}
./mycorrhiza/.env.sample:DOMAIN={{ .Domain }}
./gancio/.env.sample:DOMAIN={{ .Domain }}
./nextcloud/.env.sample:DOMAIN={{ .Domain }}
./gitea/.env.sample:DOMAIN={{ .Domain }}
💯 TODO for me is to fix up this then: ``` grep -iR "\{ \.Domain \}" . ./hometown/.env.sample:DOMAIN={{ .Domain }} ./amusewiki/.env.sample:DOMAIN={{ .Domain }} ./rsshub/.env.sample:DOMAIN={{ .Domain }} ./traefik/.env.sample:DOMAIN={{ .Domain }} ./mycorrhiza/.env.sample:DOMAIN={{ .Domain }} ./gancio/.env.sample:DOMAIN={{ .Domain }} ./nextcloud/.env.sample:DOMAIN={{ .Domain }} ./gitea/.env.sample:DOMAIN={{ .Domain }} ```
pkg/config/app.go Outdated
@@ -342,1 +330,3 @@
return err
err = ioutil.WriteFile(appEnvPath, []byte(newContents), 0)
if err != nil {
panic(err)
decentral1se commented 2022-11-14 16:01:37 +00:00
Owner
Copy Link
Copy Source

return err

`return err`
3wordchant commented 2022-11-14 17:58:19 +00:00
Author
Owner
Copy Link
Copy Source

ugh thought i caught all my half-baked copypasta, fixing!

ugh thought i caught all my half-baked copypasta, fixing!
3wordchant marked this conversation as resolved
3wordchant added 1 commit 2022-11-14 17:58:56 +00:00
fix: don't panic() 😅
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
ad38907a04
3wordchant commented 2022-11-14 18:01:25 +00:00
Author
Owner
Copy Link
Copy Source

💯

TODO for me is to fix up this then:

grep -iR "\{ \.Domain \}" .
./hometown/.env.sample:DOMAIN={{ .Domain }}
./amusewiki/.env.sample:DOMAIN={{ .Domain }}
./rsshub/.env.sample:DOMAIN={{ .Domain }}
./traefik/.env.sample:DOMAIN={{ .Domain }}
./mycorrhiza/.env.sample:DOMAIN={{ .Domain }}
./gancio/.env.sample:DOMAIN={{ .Domain }}
./nextcloud/.env.sample:DOMAIN={{ .Domain }}
./gitea/.env.sample:DOMAIN={{ .Domain }}

@decentral1se I don't mind doing that find'n'replace, up to you!

> 💯 > > TODO for me is to fix up this then: > > ``` > grep -iR "\{ \.Domain \}" . > ./hometown/.env.sample:DOMAIN={{ .Domain }} > ./amusewiki/.env.sample:DOMAIN={{ .Domain }} > ./rsshub/.env.sample:DOMAIN={{ .Domain }} > ./traefik/.env.sample:DOMAIN={{ .Domain }} > ./mycorrhiza/.env.sample:DOMAIN={{ .Domain }} > ./gancio/.env.sample:DOMAIN={{ .Domain }} > ./nextcloud/.env.sample:DOMAIN={{ .Domain }} > ./gitea/.env.sample:DOMAIN={{ .Domain }} > ``` @decentral1se I don't mind doing that find'n'replace, up to you!
decentral1se commented 2022-11-14 22:46:01 +00:00
Owner
Copy Link
Copy Source

@decentral1se I don't mind doing that find'n'replace, up to you!

@3wordchant that'd be amazing if you wanna sort that out, thanks!

This LGTM, merge away 🥇

> @decentral1se I don't mind doing that find'n'replace, up to you! @3wordchant that'd be amazing if you wanna sort that out, thanks! This LGTM, merge away 🥇
3wordchant merged commit a21d431541 into main 2022-11-24 17:34:01 +00:00
3wordchant deleted branch unsmart-templating 2022-11-24 17:34:04 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
 build
go build related issues
 ci/cd
Building things with CI/CD
 critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
 design
UI/UX
 documentation
Documenting all the things
 duplicate
This issue or pull request already exists
 easy-first-issue
Something for new people to get stuck into. We hope it's easy!
 enhancement
New feature
 help wanted
Need some help
 i10n
Everything to do with localisation
 i18n
Everything to do with internationalisation
 installer
Everything to do with the install script.
 invalid
Something is wrong
 question
More information is needed
 release
Release management
 release-candidate
Related to the new release candidate
 security
Security related
 tech-debt
test
Unit/integration testing
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm BornDeleuze Brooke carla cas (Cassowary) coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) iexos jade (Jade Ambrose) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) moosemower moritz notplants oxaliq (sorrel) p4u1 pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) renovate-bot (Comrade Renovate Bot) ripclap simon sixsmith (Sixsmith) stevensting trav (Trav Fryer) val (val (he/him)) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#228