toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

feat(cmd)!: run abra.sh commands with /bin/bash if available. #229

Closed
moritz wants to merge 2 commits from moritz/abra:main into main
pull from: moritz/abra:main
merge into: toolshed:main
Conversation 3 Commits 2 Files Changed 1 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d7d8689d53 - Show all commits

6
cli/app/cmd.go
View File

@ -87,7 +87,7 @@ Example:
sourceAndExec = fmt.Sprintf("TARGET=local; APP_NAME=%s; STACK_NAME=%s; %s . %s; %s", app.Name, app.StackName(), exportEnv, abraSh, cmdName) sourceAndExec = fmt.Sprintf("TARGET=local; APP_NAME=%s; STACK_NAME=%s; %s . %s; %s", app.Name, app.StackName(), exportEnv, abraSh, cmdName)
} }
var shell string = "/bin/bash" shell := "/bin/bash"
moritz marked this conversation as resolved Outdated
decentral1se commented 2022-11-15 15:32:59 +00:00
Outdated
Review
Copy Link

shell := "/bin/bash" is the style we've been using elsewhere in the codebase.

`shell := "/bin/bash"` is the style we've been using elsewhere in the codebase.
if _, err := os.Stat(shell); errors.Is(err, os.ErrNotExist) { if _, err := os.Stat(shell); errors.Is(err, os.ErrNotExist) {
logrus.Debugf("%s does not exist locally, use /bin/sh as fallback", shell) logrus.Debugf("%s does not exist locally, use /bin/sh as fallback", shell)
shell = "/bin/sh" shell = "/bin/sh"
@ -203,8 +203,8 @@ func runCmdRemote(app config.App, abraSh, serviceName, cmdName, cmdArgs string)
return err return err
} }
var shell string = "/bin/bash" shell := "/bin/bash"
moritz marked this conversation as resolved Outdated
decentral1se commented 2022-11-15 15:33:37 +00:00
Outdated
Review
Copy Link

shell := "/bin/bash"

`shell := "/bin/bash"`
var findShell []string = []string{"test", "-e", shell} findShell := []string{"test", "-e", shell}
moritz marked this conversation as resolved Outdated
decentral1se commented 2022-11-15 15:34:02 +00:00
Outdated
Review
Copy Link

findShell := []string{"test", "-e", shell}

`findShell := []string{"test", "-e", shell}`
execCreateOpts := types.ExecConfig{ execCreateOpts := types.ExecConfig{
AttachStderr: true, AttachStderr: true,
AttachStdin: true, AttachStdin: true,