Don't query git.coopcloud.tech when streaming logs #275

decentral1se · 2023-02-13T12:31:36Z

decentral1se commented

2023-02-13 12:31:36 +00:00

So, as title says, this covers not doing that + has a refactor to make configuring this kind of thing easier in the future.

Working on finishing up coop-cloud/organising#292 and having something extendable for later changes. It seems like there is a need to allow specific command logic to modify the internals. E.g. making decisions about how to access the network, whether or not to clone the recipes etc. etc.

So, I've tried to come up with a kind of "options" system which is the Go way to pass down optional arguments into internals. This is an improvement on the ensureLatest bool on ValidateRecipe which requires updating the code everywhere and it's not very flexible.

With this runtime.Config / Option setup, any command can modify specifics in the internals and new options can be added when further changes are needed without updating the code all over the place.

So, as title says, this covers not doing that + has a refactor to make configuring this kind of thing easier in the future. Working on finishing up https://git.coopcloud.tech/coop-cloud/organising/issues/292 and having something extendable for later changes. It seems like there is a need to allow specific command logic to modify the internals. E.g. making decisions about how to access the network, whether or not to clone the recipes etc. etc. So, I've tried to come up with a kind of "options" system which is the Go way to pass down optional arguments into internals. This is an improvement on the `ensureLatest` bool on `ValidateRecipe` which requires updating the code everywhere and it's not very flexible. With this `runtime.Config` / `Option` setup, any command can modify specifics in the internals and new options can be added when further changes are needed without updating the code all over the place.

decentral1se added 1 commit 2023-02-13 12:32:50 +00:00

fix: better error message when network gone ff58646cfc

decentral1se force-pushed further-offline-fixes from 37a655e2cf to e4b4084dfd

2023-02-13 15:46:54 +00:00

Compare

decentral1se changed title from ~~WIP: further offline fixes~~ to Don't query git.coopcloud.tech when streaming logs

2023-02-13 15:47:17 +00:00

decentral1se referenced this pull request from toolshed/organising

2023-02-13 15:49:10 +00:00

If git.coopcloud.tech is down, try to keep going with local files #292

decentral1se merged commit e4b4084dfd into main

2023-02-13 16:04:21 +00:00

decentral1se deleted branch further-offline-fixes

2023-02-13 16:04:27 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#275