toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

Attempt to fix coop-cloud/organising#452 #325

Merged
decentral1se merged 6 commits from rix/abra:docker-v24 into main 2023-07-15 08:15:53 +00:00
Conversation 1 Commits 6 Files Changed 6 +24 -14
rix commented 2023-07-14 19:56:57 +00:00
Contributor
Copy Link

This is my attempt to update the docker dependencies to the latest version (coop-cloud/organising#452). I've not actually worked with Go or Abra or even make files before so it's all a bit of an experiment. I've run make build and make test successfully as far as I can see it passes the tests so hopefully that's good enough. Let me know if there are further tests I should be doing to check everything is working ok : )

This is my attempt to update the docker dependencies to the latest version (https://git.coopcloud.tech/coop-cloud/organising/issues/452). I've not actually worked with Go or Abra or even make files before so it's all a bit of an experiment. I've run make build and make test successfully as far as I can see it passes the tests so hopefully that's good enough. Let me know if there are further tests I should be doing to check everything is working ok : )
❤️ 1
rix added 5 commits 2023-07-14 19:56:58 +00:00
Replace deprecated system.TempFileSequential with os.CreateTemp
Some checks failed
continuous-integration/drone/pr Build is failing
Details
e362926771
rix added 1 commit 2023-07-14 20:11:51 +00:00
Fix formatting.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7668fcba57
decentral1se reviewed 2023-07-15 07:57:21 +00:00
decentral1se left a comment
Owner
Copy Link

Incredible work @rix! Thanks for working on this, really appreciate the help on these tricky maintenance tasks. LGTM. Since we have few tests, it'd be good to manually tests the affected commands. That seems to be abra app backup, abra app remove. Can help with that if you're happy with this, we can just merge it.

Incredible work @rix! Thanks for working on this, really appreciate the help on these tricky maintenance tasks. LGTM. Since we have few tests, it'd be good to manually tests the affected commands. That seems to be `abra app backup`, `abra app remove`. Can help with that if you're happy with this, we can just merge it.
❤️ 1
rix changed title from WIP: Attempt to fix coop-cloud/organising#452 to Attempt to fix coop-cloud/organising#452 2023-07-15 08:09:14 +00:00
decentral1se merged commit a7ce71d6cf into main 2023-07-15 08:15:53 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#325
No description provided.
Delete Branch "rix/abra:docker-v24"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?