Integration test suite first steps... #347

2023-09-05T09:18:16Z

decentral1se commented

2023-09-05 09:18:16 +00:00

As planned with @3wordchant, optimise for local developer workflow first and patch abra to support a ~/.abra_test directory. This can be configured with ABRA_TEST=.... Maybe you had a thought on the naming of this var @3wordchant? This is working well so far and I even caught a bug already, which makes me feel like it's the way to go. With a dedicated test server setup later on, I think we could get a solid test coverage for abra with this. Lemme know what you think folks! Kept the diff small so it's easy to review / grok before moving ahead.

apt install bats git make bats-support bats-assert
bats tests/integration

As planned with @3wordchant, optimise for local developer workflow first and patch `abra` to support a `~/.abra_test` directory. This can be configured with `ABRA_TEST=...`. Maybe you had a thought on the naming of this var @3wordchant? This is working well so far and I even caught a bug already, which makes me feel like it's the way to go. With a dedicated test server setup later on, I think we could get a solid test coverage for `abra` with this. Lemme know what you think folks! Kept the diff small so it's easy to review / grok before moving ahead. ``` apt install bats git make bats-support bats-assert bats tests/integration ```

decentral1se added 5 commits 2023-09-05 09:18:36 +00:00

feat: support abra testing mode 03b4e4b4e2

test: write initial automatic integration tests 617e8d9409

fix: only load client if creating secrets 5af3e9c32d

fix: clone catalogue on initial run 9a0437d116

chore: don't join if nothing to join

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is failing

Details

fcd3c9fc41

decentral1se reviewed 2023-09-05 09:20:31 +00:00

tests/integration/helpers.sh Outdated

						
				@@ -0,0 +10,4 @@

				_build_kadabra() {

				  if [[ ! -e "$ROOT/kadabra" ]]; then

				      cd "$ROOT" && make build-dev

decentral1se commented

2023-09-05 09:20:31 +00:00

Oops, that's wrong, Need a dedicated kadabra makefile target. TODO 🤓

Oops, that's wrong, Need a dedicated `kadabra` makefile target. TODO 🤓

decentral1se marked this conversation as resolved

3wordchant approved these changes 2023-09-05 09:33:57 +00:00

pkg/config/env.go

						
				@@ -17,1 +17,3 @@

				var ABRA_DIR = os.ExpandEnv("$HOME/.abra")

				// getBaseDir retrieves the Abra base directory.

				func getBaseDir() string {

					home := os.ExpandEnv("$HOME/.abra")

3wordchant commented

2023-09-05 09:33:15 +00:00

What about making the env var ABRA_DIR, and defaulting to $HOME/.abra? then for tests ABRA_DIR=$HOME/.abra_test, and folks could also choose to put the directory elsewhere for homedir-neatness reasons, or in the case of an immutable home dir.

What about making the env var `ABRA_DIR`, and defaulting to `$HOME/.abra`? then for tests `ABRA_DIR=$HOME/.abra_test`, and folks could also choose to put the directory elsewhere for homedir-neatness reasons, or in the case of an immutable home dir.

decentral1se marked this conversation as resolved

decentral1se added 2 commits 2023-09-05 09:57:59 +00:00

fix: separate abra/kababra makefile targets 0ee13b427a

fix: overridable ABRA_DIR

continuous-integration/drone/push Build is failing

Details

continuous-integration/drone/pr Build is failing

Details

46eb5762d8

decentral1se merged commit 58e78e4d7c into main

2023-09-05 09:58:14 +00:00

decentral1se deleted branch integration-tests

2023-09-05 09:58:24 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#347