toolshed/abra
4
2
Fork 18
Code Issues 35 Pull Requests 3 Packages Releases 40 Activity

Fix ls -S to deal with broken/unparsable app versions more correctly #385

Closed
cas wants to merge 2 commits from cr_fix_ls-S into cr_dockerinside
pull from: cr_fix_ls-S
merge into: toolshed:cr_dockerinside
Conversation 3 Commits 2 Files Changed 1 +15 -12
cas commented 2023-11-09 18:54:21 +00:00
Member
Copy Link

Fix error handling inside abra app ls -S so that it outputs competent / useful output even if versions can't be parsed.

[is a branch from cr_dockerinside, so merge afterwards]

Fix error handling inside `abra app ls -S` so that it outputs competent / useful output even if versions can't be parsed. [is a branch from cr_dockerinside, so merge afterwards]
❤️ 2
cas added 1 commit 2023-11-09 18:54:21 +00:00
Fix ls -S to deal with broken/unparsable app versions more correctly
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
3939971d82
cas added 1 commit 2023-11-09 19:14:27 +00:00
Better logical layout for app ls -S
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
d041deec68
decentral1se reviewed 2023-11-27 10:26:32 +00:00
cli/app/list.go
@ -182,3 +179,2 @@
logrus.Fatal(err)
}
if (version != "unknown") {
decentral1se commented 2023-11-27 10:26:32 +00:00
Owner
Copy Link

(...) not required?

`(...)` not required?
decentral1se reviewed 2023-11-27 10:27:13 +00:00
decentral1se left a comment
Owner
Copy Link

Thanks! Would it be possible to get a test for this one? Or if you're confident to merge as-is, please go for it! Not sure how to test this myself right now.

Thanks! Would it be possible to get a test for this one? Or if you're confident to merge as-is, please go for it! Not sure how to test this myself right now.
decentral1se closed this pull request 2024-03-11 13:04:39 +00:00
decentral1se commented 2024-03-11 13:07:27 +00:00
Owner
Copy Link

Oh dear dog I accidentally deleted the branch for this, I'm sorry 😱 Have you still got a copy @cas?

Oh dear dog I accidentally deleted the branch for this, I'm sorry 😱 Have you still got a copy @cas?
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
red abya yala
Work funded by Calyx institute for Red Abya Yala
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#385
No description provided.
Delete Branch "cr_fix_ls-S"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?