toolshed/abra
4
4
Fork 23
Code Issues 82 Pull Requests 11 Packages Releases 45 Activity

Fix ls -S to deal with broken/unparsable app versions more correctly #385

Closed
cas wants to merge 2 commits from cr_fix_ls-S into cr_dockerinside
pull from: cr_fix_ls-S
merge into: :cr_dockerinside
Conversation 3 Commits 2 Files Changed 1
+15 -12
cas commented 2023-11-09 18:54:21 +00:00
Member
Copy Link
Copy Source

Fix error handling inside abra app ls -S so that it outputs competent / useful output even if versions can't be parsed.

[is a branch from cr_dockerinside, so merge afterwards]

Fix error handling inside `abra app ls -S` so that it outputs competent / useful output even if versions can't be parsed. [is a branch from cr_dockerinside, so merge afterwards]
❤️ 2
cas added 1 commit 2023-11-09 18:54:21 +00:00
Fix ls -S to deal with broken/unparsable app versions more correctly
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
3939971d82
cas added 1 commit 2023-11-09 19:14:27 +00:00
Better logical layout for app ls -S
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
d041deec68
decentral1se reviewed 2023-11-27 10:26:32 +00:00
cli/app/list.go
@@ -182,3 +179,2 @@
logrus.Fatal(err)
}
if (version != "unknown") {
decentral1se commented 2023-11-27 10:26:32 +00:00
Owner
Copy Link
Copy Source

(...) not required?

`(...)` not required?
decentral1se reviewed 2023-11-27 10:27:13 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

Thanks! Would it be possible to get a test for this one? Or if you're confident to merge as-is, please go for it! Not sure how to test this myself right now.

Thanks! Would it be possible to get a test for this one? Or if you're confident to merge as-is, please go for it! Not sure how to test this myself right now.
decentral1se closed this pull request 2024-03-11 13:04:39 +00:00
decentral1se commented 2024-03-11 13:07:27 +00:00
Owner
Copy Link
Copy Source

Oh dear dog I accidentally deleted the branch for this, I'm sorry 😱 Have you still got a copy @cas?

Oh dear dog I accidentally deleted the branch for this, I'm sorry 😱 Have you still got a copy @cas?

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
 build
go build related issues
 ci/cd
Building things with CI/CD
 critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
 design
UI/UX
 documentation
Documenting all the things
 duplicate
This issue or pull request already exists
 easy-first-issue
Something for new people to get stuck into. We hope it's easy!
 enhancement
New feature
 help wanted
Need some help
 i10n
Everything to do with localisation
 i18n
Everything to do with internationalisation
 installer
Everything to do with the install script.
 invalid
Something is wrong
 question
More information is needed
 release
Release management
 release-candidate
Related to the new release candidate
 security
Security related
 tech-debt
test
Unit/integration testing
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm BornDeleuze Brooke carla cas (Cassowary) coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) iexos jade (Jade Ambrose) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) moosemower moritz notplants oxaliq (sorrel) p4u1 pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) renovate-bot (Comrade Renovate Bot) ripclap simon sixsmith (Sixsmith) stevensting trav (Trav Fryer) val (val (he/him)) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#385