toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

WIP: untie server name from a domain #398

Closed
wykwit wants to merge 3 commits from wykwit/abra:server-name into main
pull from: wykwit/abra:server-name
merge into: toolshed:main
Conversation 3 Commits 3 Files Changed 4 +27 -17
wykwit commented 2024-01-06 01:36:41 +00:00
First-time contributor
Copy Link

The convention of mapping names to domains was driving me crazy.

This fix resolves the actual server hostname according to host entry in the SSH config, allows for using any server name, but most importantly allows for adding local machines as servers.
Turns out that's enough to use abra for LAN-only deployments.

Default behaviors shouldn't change.

The convention of mapping names to domains was driving me crazy. This fix resolves the actual server hostname according to host entry in the SSH config, allows for using any server name, but most importantly allows for adding local machines as servers. Turns out that's enough to use `abra` for LAN-only deployments. Default behaviors shouldn't change.
wykwit added 2 commits 2024-01-06 01:36:41 +00:00
fix: make dns resolve errors more accurate
All checks were successful
continuous-integration/drone/pr Build is passing
Details
fd15aeab9a
decentral1se reviewed 2024-01-06 09:18:00 +00:00
decentral1se left a comment
Owner
Copy Link

Solid stuff! One minor comment.

I think it'd be nice if you could add an integration test for this?

Solid stuff! One minor comment. I think it'd be nice if you could add an integration test for this?
👍 1
cli/server/add.go Outdated
@ -169,1 +175,4 @@
if err := newContext(c, domainName, hostConfig.Host, hostConfig.User, hostConfig.Port); err != nil {
logrus.Fatal(err)
cleanUp(domainName)
decentral1se commented 2024-01-06 09:15:42 +00:00
Owner
Copy Link

Doesn't this need to go before the logrus.Fatal call?

Doesn't this need to go before the `logrus.Fatal` call?
wykwit commented 2024-01-06 12:49:09 +00:00
Author
First-time contributor
Copy Link

Good catch, thanks!

Good catch, thanks!
decentral1se marked this conversation as resolved
wykwit added 1 commit 2024-01-06 12:48:12 +00:00
fix: clean up before panic in server add command
All checks were successful
continuous-integration/drone/pr Build is passing
Details
4db15d8530
decentral1se commented 2024-03-27 05:41:48 +00:00
Owner
Copy Link

@wykwit got any cycles to take another run at this?

@wykwit got any cycles to take another run at this?
decentral1se changed title from Untie server name from a domain to WIP: untie server name from a domain 2024-03-27 05:43:22 +00:00
decentral1se commented 2024-06-24 22:29:23 +00:00
Owner
Copy Link

Merged in 9bf44c15ed / d787f71215 and also coop-cloud/abra#415

Merged in 9bf44c15ed63555ef5e8aa0db901544cdaad67fb / d787f7121506c7588c5c52cfcf127cbe4100f931 and also https://git.coopcloud.tech/coop-cloud/abra/pulls/415
decentral1se closed this pull request 2024-06-24 22:29:23 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#398
No description provided.
Delete Branch "wykwit/abra:server-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?