toolshed/abra
4
4
Fork 23
Code Issues 82 Pull Requests 11 Packages Releases 45 Activity

WIP: untie server name from a domain #398

Closed
wykwit wants to merge 3 commits from wykwit/abra:server-name into main
pull from: wykwit/abra:server-name
merge into: :main
Conversation 3 Commits 3 Files Changed 4
+27 -17
wykwit commented 2024-01-06 01:36:41 +00:00
First-time contributor
Copy Link
Copy Source

The convention of mapping names to domains was driving me crazy.

This fix resolves the actual server hostname according to host entry in the SSH config, allows for using any server name, but most importantly allows for adding local machines as servers.
Turns out that's enough to use abra for LAN-only deployments.

Default behaviors shouldn't change.

The convention of mapping names to domains was driving me crazy. This fix resolves the actual server hostname according to host entry in the SSH config, allows for using any server name, but most importantly allows for adding local machines as servers. Turns out that's enough to use `abra` for LAN-only deployments. Default behaviors shouldn't change.
wykwit added 2 commits 2024-01-06 01:36:41 +00:00
feat: untie server name from a domain in the add command 5d503319e3
fix: make dns resolve errors more accurate
continuous-integration/drone/pr Build is passing
Details
fd15aeab9a
decentral1se reviewed 2024-01-06 09:18:00 +00:00
decentral1se left a comment
Owner
Copy Link
Copy Source

Solid stuff! One minor comment.

I think it'd be nice if you could add an integration test for this?

Solid stuff! One minor comment. I think it'd be nice if you could add an integration test for this?
👍 1
cli/server/add.go Outdated
@@ -169,1 +175,4 @@
if err := newContext(c, domainName, hostConfig.Host, hostConfig.User, hostConfig.Port); err != nil {
logrus.Fatal(err)
cleanUp(domainName)
decentral1se commented 2024-01-06 09:15:42 +00:00
Owner
Copy Link
Copy Source

Doesn't this need to go before the logrus.Fatal call?

Doesn't this need to go before the `logrus.Fatal` call?
wykwit commented 2024-01-06 12:49:09 +00:00
Author
First-time contributor
Copy Link
Copy Source

Good catch, thanks!

Good catch, thanks!
decentral1se marked this conversation as resolved
wykwit added 1 commit 2024-01-06 12:48:12 +00:00
fix: clean up before panic in server add command
continuous-integration/drone/pr Build is passing
Details
4db15d8530
decentral1se commented 2024-03-27 05:41:48 +00:00
Owner
Copy Link
Copy Source

@wykwit got any cycles to take another run at this?

@wykwit got any cycles to take another run at this?
decentral1se changed title from Untie server name from a domain to WIP: untie server name from a domain 2024-03-27 05:43:22 +00:00
decentral1se commented 2024-06-24 22:29:23 +00:00
Owner
Copy Link
Copy Source

Merged in 9bf44c15ed / d787f71215 and also coop-cloud/abra#415

Merged in 9bf44c15ed63555ef5e8aa0db901544cdaad67fb / d787f7121506c7588c5c52cfcf127cbe4100f931 and also https://git.coopcloud.tech/coop-cloud/abra/pulls/415
decentral1se closed this pull request 2024-06-24 22:29:23 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
This pull request is marked as a work in progress.
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
 build
go build related issues
 ci/cd
Building things with CI/CD
 critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
 design
UI/UX
 documentation
Documenting all the things
 duplicate
This issue or pull request already exists
 easy-first-issue
Something for new people to get stuck into. We hope it's easy!
 enhancement
New feature
 help wanted
Need some help
 i10n
Everything to do with localisation
 i18n
Everything to do with internationalisation
 installer
Everything to do with the install script.
 invalid
Something is wrong
 question
More information is needed
 release
Release management
 release-candidate
Related to the new release candidate
 security
Security related
 tech-debt
test
Unit/integration testing
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm BornDeleuze Brooke carla cas (Cassowary) coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) iexos jade (Jade Ambrose) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) moosemower moritz notplants oxaliq (sorrel) p4u1 pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) renovate-bot (Comrade Renovate Bot) ripclap simon sixsmith (Sixsmith) stevensting trav (Trav Fryer) val (val (he/him)) yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#398