toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 27 Pull Requests 3 Packages Releases 40 Activity

fix: retry docker volume remove #399

Merged
p4u1 merged 1 commits from p4u1/abra:remove-retry into main 2024-01-19 15:09:01 +00:00
Conversation 3 Commits 1 Files Changed 3 +51 -9
p4u1 commented 2024-01-08 11:36:24 +00:00
Member
Copy Link

Closes coop-cloud/organising#509

Closes https://git.coopcloud.tech/coop-cloud/organising/issues/509
decentral1se reviewed 2024-01-08 15:04:53 +00:00
cli/app/remove.go Outdated
@ -144,2 +148,4 @@
},
}
func retryFunc(retries int, fn func() error) error {
decentral1se commented 2024-01-08 15:04:53 +00:00
Owner
Copy Link

An 'ol docstring might be nice.

An 'ol docstring might be nice.
p4u1 commented 2024-01-08 15:52:46 +00:00
Author
Member
Copy Link

I added a docstring and also a unit test

I added a docstring and also a unit test
👍 1
decentral1se marked this conversation as resolved
decentral1se approved these changes 2024-01-08 15:05:03 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM 🚀

LGTM 🚀
p4u1 force-pushed remove-retry from 25482352b4 to 526c0b8ac3 2024-01-08 15:52:11 +00:00 Compare
decentral1se approved these changes 2024-01-08 20:57:29 +00:00
decentral1se left a comment
Owner
Copy Link

💖

💖
p4u1 merged commit 4920dfedb3 into main 2024-01-19 15:09:01 +00:00
p4u1 deleted branch remove-retry 2024-01-19 15:09:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#399
No description provided.
Delete Branch "p4u1/abra:remove-retry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?