toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 27 Pull Requests 3 Packages Releases 40 Activity

feat: add version input to abra app new #400

Merged
p4u1 merged 1 commits from p4u1/abra:app-new-version into main 2024-01-19 15:08:42 +00:00
Conversation 2 Commits 1 Files Changed 3 +75 -16
p4u1 commented 2024-01-08 12:34:14 +00:00
Member
Copy Link

Closes coop-cloud/organising#519

Closes https://git.coopcloud.tech/coop-cloud/organising/issues/519
decentral1se approved these changes 2024-01-08 15:03:13 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM 🤘

LGTM 🤘
tests/integration/app_new.bats Outdated
@ -24,0 +30,4 @@
run $ABRA app new abra-test-recipe --generate-bash-completion
assert_success
assert_output "0.1.0+1.20.0
decentral1se commented 2024-01-08 15:02:18 +00:00
Owner
Copy Link

Maybe --partial here to avoid having to update this test? Or leave a comment with TODO to signal that we know this will break and that it needs updating when the test recipe gets an update.

Maybe `--partial` here to avoid having to update this test? Or leave a comment with `TODO` to signal that we know this will break and that it needs updating when the test recipe gets an update.
👍 1
p4u1 commented 2024-01-08 15:43:27 +00:00
Author
Member
Copy Link

I added a comment to signal, that this will break :)

I added a comment to signal, that this will break :)
decentral1se marked this conversation as resolved
p4u1 force-pushed app-new-version from ec0e21d9c1 to 0a9ae04474 2024-01-08 15:40:32 +00:00 Compare
decentral1se approved these changes 2024-01-08 20:58:12 +00:00
decentral1se left a comment
Owner
Copy Link

👌

👌
p4u1 merged commit 0a3624c15b into main 2024-01-19 15:08:42 +00:00
p4u1 deleted branch app-new-version 2024-01-19 15:08:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#400
No description provided.
Delete Branch "p4u1/abra:app-new-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?