toolshed/abra
4
3
Fork 19
Code Issues 39 Pull Requests 4 Packages Releases 42 Activity

refactor!: drop version, show versions in ps #429

Merged
decentral1se merged 1 commits from improve-ps-drop-version into main 2024-07-08 12:44:03 +00:00
Conversation 3 Commits 1 Files Changed 5 +32 -215
decentral1se commented 2024-07-08 10:00:46 +00:00
Owner
Copy Link

coop-cloud/organising#526 coop-cloud/organising#502

abra app version is a bit of an outlier and increases the command API surface. Instead, why don't we just put the deployed version and chaos version in the abra app ps output and remove abra app version. This makes ps output more useful, which is used more.

We use cell merging to avoid duplication of output:

image

https://git.coopcloud.tech/coop-cloud/organising/issues/526 https://git.coopcloud.tech/coop-cloud/organising/issues/502 `abra app version` is a bit of an outlier and increases the command API surface. Instead, why don't we just put the deployed version and chaos version in the `abra app ps` output and remove `abra app version`. This makes `ps` output more useful, which is used more. We use cell merging to avoid duplication of output: ![image](/attachments/57abc754-2d11-4b99-9403-89a0bf2497a8)
image.png
161 KiB
p4u1 commented 2024-07-08 11:51:57 +00:00
Member
Copy Link

looking good!

looking good!
🎉 1
p4u1 approved these changes 2024-07-08 11:52:03 +00:00
decentral1se commented 2024-07-08 12:07:55 +00:00
Author
Owner
Copy Link

Pending coop-cloud/abra#430 merge & rebase 🤓

Pending https://git.coopcloud.tech/coop-cloud/abra/pulls/430 merge & rebase 🤓
decentral1se force-pushed improve-ps-drop-version from 8e13f810e5 to 5426464092 2024-07-08 12:42:12 +00:00 Compare
decentral1se merged commit 5426464092 into main 2024-07-08 12:44:03 +00:00
decentral1se deleted branch improve-ps-drop-version 2024-07-08 12:44:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
p4u1
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#429
No description provided.
Delete Branch "improve-ps-drop-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?