toolshed/abra
4
3
Fork 19
Code Issues 39 Pull Requests 4 Packages Releases 42 Activity

feat: introduce remote recipes #432

Merged
p4u1 merged 4 commits from p4u1/abra:remote-recipe-after-refactor into main 2024-07-10 10:25:07 +00:00
Conversation 4 Commits 4 Files Changed 25 +241 -178
p4u1 commented 2024-07-08 13:14:56 +00:00
Member
Copy Link

With this you can set RECIPE=codeberg.org/Klasse-Methode/eintopf-recipe!

Working on coop-cloud/organising#533

With this you can set `RECIPE=codeberg.org/Klasse-Methode/eintopf-recipe`! Working on https://git.coopcloud.tech/coop-cloud/organising/issues/533
🎉 1
p4u1 force-pushed remote-recipe-after-refactor from f4747d0674 to 82c284c42a 2024-07-08 13:16:51 +00:00 Compare
decentral1se reviewed 2024-07-08 13:33:03 +00:00
decentral1se left a comment
Owner
Copy Link

🧨

🧨
decentral1se reviewed 2024-07-08 14:30:49 +00:00
cli/app/deploy.go Outdated
@ -116,3 +113,1 @@
versions, err := recipe.GetRecipeCatalogueVersions(app.Recipe.Name, catl)
if err != nil {
log.Fatal(err)
log.Warn(err)
decentral1se commented 2024-07-08 14:29:55 +00:00
Owner
Copy Link

Should we keep the Fatal call here?

Should we keep the `Fatal` call here?
👍 1
p4u1 marked this conversation as resolved
cli/app/list.go Outdated
@ -187,3 +179,1 @@
if err != nil {
log.Fatal(err)
}
updates, err := app.Recipe.Tags()
decentral1se commented 2024-07-08 14:30:16 +00:00
Owner
Copy Link

Missing err checking?

Missing `err` checking?
👍 1
p4u1 marked this conversation as resolved
p4u1 force-pushed remote-recipe-after-refactor from 09cee5159d to d1b536925f 2024-07-08 14:49:17 +00:00 Compare
p4u1 force-pushed remote-recipe-after-refactor from 47a1570f8e to 92e40a0ef9 2024-07-08 15:14:24 +00:00 Compare
p4u1 force-pushed remote-recipe-after-refactor from a4f2604c73 to 2176b1f74c 2024-07-08 16:00:38 +00:00 Compare
decentral1se commented 2024-07-09 09:45:37 +00:00
Owner
Copy Link

Sorry for rebase chaos 🙈 👩‍🚒

Sorry for rebase chaos 🙈 👩‍🚒
p4u1 commented 2024-07-09 16:47:50 +00:00
Author
Member
Copy Link

@decentral1se

Sorry for rebase chaos 🙈 👩‍🚒

My fault, should have merged sooner :D

@decentral1se >Sorry for rebase chaos 🙈 👩‍🚒 My fault, should have merged sooner :D
😆 1
p4u1 force-pushed remote-recipe-after-refactor from 2176b1f74c to 7596982282 2024-07-10 10:12:55 +00:00 Compare
p4u1 merged commit f6b7510da6 into main 2024-07-10 10:25:07 +00:00
p4u1 deleted branch remote-recipe-after-refactor 2024-07-10 10:25:07 +00:00
p4u1 referenced this issue from a commit 2024-07-10 10:25:08 +00:00
feat: introduce remote recipes
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#432
No description provided.
Delete Branch "p4u1/abra:remote-recipe-after-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?