fix: use old auto-completion for 0.9.x compat #446

decentral1se · 2024-10-27T07:57:47Z

decentral1se commented

2024-10-27 07:57:47 +00:00

Partial revert of 1f8662cd95

@fauno @3wordchant this looks good? I revert the latest changes so that the current release version will continue to work. I'll revert this when we make the next release. Maybe you can download the files and test them?

Need to keep this in mind when doing the release. We need to patch the URL to match the version. And we can think about whether it's worth patching 0.9.x for backwards compat vs. asking people to upgrade (patch/release is quite a bitta work... with all the CI stuff...)

See https://git.coopcloud.tech/toolshed/organising/issues/644 Partial revert of 1f8662cd9518c3d1e14d058f2a88d438b59170b2 @fauno @3wordchant this looks good? I revert the latest changes so that the current release version will continue to work. I'll revert this when we make the next release. Maybe you can download the files and test them? Need to keep this in mind when doing the release. We need to patch the URL to match the version. And we can think about whether it's worth patching 0.9.x for backwards compat vs. asking people to upgrade (patch/release is quite a bitta work... with all the CI stuff...)

decentral1se added 1 commit 2024-10-27 07:57:47 +00:00

fix: use old auto-completion for 0.9.x compat

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details

b313b0a145

See toolshed/organising#644

Partial revert of 1f8662cd9518c3d1e14d058f2a88d438b59170b2

decentral1se requested review from 3wordchant 2024-10-28 09:27:29 +00:00

decentral1se requested review from fauno 2024-10-28 09:27:30 +00:00

decentral1se commented

2024-10-28 10:59:18 +00:00

I think i can follow this up with a scripts/autocomplete/0.10/ directory to unbreak the current unreleased functionality then. I can hopefully pass the version into the function to match the path. So future versions won't break the same way. That should sort backwards/forwards compat on this.

I think i can follow this up with a `scripts/autocomplete/0.10/` directory to unbreak the current unreleased functionality then. I can hopefully pass the version into the function to match the path. So future versions won't break the same way. That should sort backwards/forwards compat on this.

fauno commented

2024-10-28 12:16:45 +00:00

I think i can follow this up with a scripts/autocomplete/0.10/ directory to unbreak the current unreleased functionality then. I can hopefully pass the version into the function to match the path. So future versions won't break the same way. That should sort backwards/forwards compat on this.

+1 to this! how can i can test this? just repeat the autocomplete suggested commands on the machine that had broken autocomplete?

i've always wondered why it needs to be a separate step, but i guess it's because abra isn't packaged, right? i could create a PKGBUILD for arch and an APKBUILD for alpine at some point. debian packaging has always been a mistery to me :b

> I think i can follow this up with a `scripts/autocomplete/0.10/` directory to unbreak the current unreleased functionality then. I can hopefully pass the version into the function to match the path. So future versions won't break the same way. That should sort backwards/forwards compat on this. +1 to this! how can i can test this? just repeat the autocomplete suggested commands on the machine that had broken autocomplete? i've always wondered why it needs to be a separate step, but i guess it's because abra isn't packaged, right? i could create a PKGBUILD for arch and an APKBUILD for alpine at some point. debian packaging has always been a mistery to me :b

🚀 1

decentral1se commented

2024-10-28 12:20:53 +00:00

@fauno i think you can click "files changed" and then "view file" on the autocompletion file for your shell. then put it in the right place (e.g. abra autocomplete bash will tell you more).

re: packaging, someone did make a start. but yeh, we have no official distro integration which would wire this up automagically atm.

@fauno i think you can click ["files changed"](https://git.coopcloud.tech/coop-cloud/abra/pulls/446/files) and then "view file" on the autocompletion file for your shell. then put it in the right place (e.g. `abra autocomplete bash` will tell you more). re: packaging, someone did make [a start](https://git.coopcloud.tech/toolshed/aur-abra-git). but yeh, we have no official distro integration which would wire this up automagically atm.

decentral1se merged commit b313b0a145 into main

2024-10-29 16:05:57 +00:00

decentral1se deleted branch fix-autocompletion

2024-10-29 16:05:58 +00:00

decentral1se commented

2024-10-29 16:06:36 +00:00

I think this is working 💣 🙏

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/abra#446