refactor!: spf13/cobra migrate #452

decentral1se · 2024-12-21T19:48:39Z

decentral1se commented

2024-12-21 19:48:39 +00:00

Drunk zombie continuation of coop-cloud/abra#443 with cobra.

Building the new CLI in the shell of the old.

migrate to spf13/cobra
fix -- handling, support flexible arg/flag handling
compatible sub-command name to autocompletion
docstring handling of flags ("--double/-single" & quotes)
manpages (abra man)
decomissioning internal/cli.go as much as possible
<domain> -> <app> in docstrings
ValidateX2 -> ValidateX
consisent use of <>/[] in docstrings
ensure validation is wired up correctly (+ len(args))
completion for arguments (also, flags this time!)
~~custom error handler to use slog/log machinery~~ (not possible yet)

Closes

🔥🔥🔥 Breaking changes 🔥🔥🔥

ge/gn -> e/N on recipe new (cobra ticket)

Drunk zombie continuation of https://git.coopcloud.tech/coop-cloud/abra/pulls/443 with [cobra](https://cobra.dev). Building the new CLI in the shell of the old. - [x] migrate to `spf13/cobra` - [x] fix `--` handling, support flexible arg/flag handling - [x] compatible sub-command name to autocompletion - [x] docstring handling of flags ("--double/-single" & quotes) - [x] manpages (`abra man`) - [x] decomissioning `internal/cli.go` as much as possible - [x] `<domain>` -> `<app>` in docstrings - [x] `ValidateX2` -> `ValidateX` - [x] consisent use of `<>/[]` in docstrings - [x] ensure [validation](https://cobra.dev/#positional-and-custom-arguments) is wired up correctly (+ `len(args)`) - [x] completion for arguments (also, flags this time!) - [x] ~~custom error handler to use `slog`/`log` machinery~~ ([not possible yet](https://github.com/spf13/cobra/pull/2199)) ## Closes - https://git.coopcloud.tech/toolshed/organising/issues/653 - https://git.coopcloud.tech/toolshed/organising/issues/645 - https://git.coopcloud.tech/toolshed/organising/issues/590 ## 🔥🔥🔥 Breaking changes 🔥🔥🔥 - `ge`/`gn` -> `e/N` on `recipe new` ([`cobra` ticket](https://github.com/spf13/cobra/issues/2208))

decentral1se added 1 commit 2024-12-21 19:48:39 +00:00

wip: another cobra migrate attempt

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

9dbf361541

decentral1se force-pushed cobra-migrate-again from 9dbf361541 to b052f355db

2024-12-22 13:31:04 +00:00

Compare

decentral1se force-pushed cobra-migrate-again from b052f355db to b627780583

2024-12-22 13:54:47 +00:00