toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: create release dir in recipe if not exists #660 #456

Merged
yksflip merged 1 commits from 660-fix-recipe-release-dir into main 2024-12-29 18:12:53 +00:00
Conversation 2 Commits 1 Files Changed 1 +9 -2
yksflip commented 2024-12-28 16:07:38 +00:00
Member
Copy Link

on the other hand we could also create the dir for abrea recipe new but I think this check might be good for existing recipes too

on the other hand we could also create the dir for `abrea recipe new` but I think this check might be good for existing recipes too
yksflip added 1 commit 2024-12-28 16:07:38 +00:00
fix: create release dir in recipe if not exists #660
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
0795605a0d
decentral1se reviewed 2024-12-28 16:20:36 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM, nice one! Feel free to merge it. I'd like to add an integration test for this. If you don't manage, I'll come back to it.

LGTM, nice one! Feel free to merge it. I'd like to add an integration test for this. If you don't manage, I'll come back to it.
yksflip commented 2024-12-28 16:30:25 +00:00
Author
Member
Copy Link

thanks :) haven't looked into the testing yet, but I'll give it a try!

thanks :) haven't looked into the testing yet, but I'll give it a try!
🎉 1
yksflip merged commit 74108b0dd9 into main 2024-12-29 18:12:53 +00:00
yksflip deleted branch 660-fix-recipe-release-dir 2024-12-29 18:12:53 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#456
No description provided.
Delete Branch "660-fix-recipe-release-dir"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?