cli/app/deploy.go

@@ -179,7 +179,9 @@ checkout as-is. Recipe commit hashes are also supported as values for
 		appPkg.ExposeAllEnv(stackName, compose, app.Env)
 		appPkg.SetRecipeLabel(compose, stackName, app.Recipe.Name)
 		appPkg.SetChaosLabel(compose, stackName, internal.Chaos)
-		appPkg.SetChaosVersionLabel(compose, stackName, toDeployChaosVersionLabel)
+		if internal.Chaos {
+			appPkg.SetChaosVersionLabel(compose, stackName, toDeployChaosVersionLabel)
+		}
 		appPkg.SetUpdateLabel(compose, stackName, app.Env)
 
 		envVars, err := appPkg.CheckEnv(app)

cli/app/rollback.go

@@ -178,7 +178,9 @@ beforehand. See "abra app backup" for more.`,
 		appPkg.ExposeAllEnv(stackName, compose, app.Env)
 		appPkg.SetRecipeLabel(compose, stackName, app.Recipe.Name)
 		appPkg.SetChaosLabel(compose, stackName, internal.Chaos)
-		appPkg.SetChaosVersionLabel(compose, stackName, chosenDowngrade)
+		if internal.Chaos {
+			appPkg.SetChaosVersionLabel(compose, stackName, chosenDowngrade)
+		}
 		appPkg.SetUpdateLabel(compose, stackName, app.Env)
 
 		chaosVersion := config.CHAOS_DEFAULT

cli/app/upgrade.go

@@ -183,7 +183,9 @@ beforehand. See "abra app backup" for more.`,
 		appPkg.ExposeAllEnv(stackName, compose, app.Env)
 		appPkg.SetRecipeLabel(compose, stackName, app.Recipe.Name)
 		appPkg.SetChaosLabel(compose, stackName, internal.Chaos)
-		appPkg.SetChaosVersionLabel(compose, stackName, chosenUpgrade)
+		if internal.Chaos {
+			appPkg.SetChaosVersionLabel(compose, stackName, chosenUpgrade)
+		}
 		appPkg.SetUpdateLabel(compose, stackName, app.Env)
 
 		envVars, err := appPkg.CheckEnv(app)

cli/internal/deploy.go

@@ -64,6 +64,15 @@ func NewVersionOverview(
 
 	upperKind := strings.ToUpper(kind)
 
+	envVersion, err := recipe.GetEnvVersionRaw(app.Recipe.Name)
+	if err != nil {
+		return err
+	}
+
+	if envVersion == "" {
+		envVersion = config.NO_VERSION_DEFAULT
+	}
+
 	rows := [][]string{
 		{"DOMAIN", domain},
 		{"RECIPE", app.Recipe.Name},
@@ -78,7 +87,7 @@ func NewVersionOverview(
 		{"VERSION", formatter.BoldDirtyDefault(toDeployVersion)},
 
 		{fmt.Sprintf("%s.ENV", strings.ToUpper(app.Domain)), "---"},
-		{"CURRENT VERSION", formatter.BoldDirtyDefault(app.Recipe.EnvVersion)},
+		{"CURRENT VERSION", formatter.BoldDirtyDefault(envVersion)},
 		{"NEW VERSION", formatter.BoldDirtyDefault(toDeployVersion)},
 	}
 

tests/integration/app_deploy.bats

@@ -21,8 +21,8 @@ setup(){
 
 teardown(){
   _reset_recipe
-  _reset_app
   _undeploy_app
+  _reset_app
   _reset_tags
 
   run rm -rf "$ABRA_DIR/recipes/$TEST_RECIPE/foo"
@@ -429,3 +429,12 @@ teardown(){
   assert_success
   assert_output --partial "$latestRelease"
 }
+
+# bats test_tags=slow
+@test "no chaos version label if no chaos" {
+  _deploy_app
+
+  run $ABRA app labels "$TEST_APP_DOMAIN" --no-input
+  assert_success
+  refute_output --regexp "coop-cloud.abra-test-recipe.$TEST_SERVER.chaos-version"
+}

tests/integration/app_deploy_overview.bats

@@ -20,8 +20,8 @@ setup(){
 
 teardown(){
   _reset_recipe
-  _reset_app
   _undeploy_app
+  _reset_app
   _reset_tags
 
   run rm -rf "$ABRA_DIR/recipes/$TEST_RECIPE/foo"

tests/integration/app_env.bats

@@ -20,8 +20,8 @@ setup(){
 
 teardown(){
   _reset_recipe
-  _reset_app
   _undeploy_app
+  _reset_app
 
   run rm -rf "$ABRA_DIR/recipes/$TEST_RECIPE/foo"
   assert_not_exists "$ABRA_DIR/recipes/$TEST_RECIPE/foo"

tests/integration/app_labels.bats

@@ -21,8 +21,8 @@ setup(){
 
 teardown(){
   _reset_recipe
-  _reset_app
   _undeploy_app
+  _reset_app
   _reset_tags
 
   run rm -rf "$ABRA_DIR/recipes/$TEST_RECIPE/foo"

tests/integration/app_rollback.bats

@@ -19,6 +19,7 @@ setup(){
 }
 
 teardown(){
+  _reset_app
   _undeploy_app
   _reset_recipe
 }
@@ -185,3 +186,16 @@ teardown(){
   assert_failure
   assert_output --partial "not a known version"
 }
+
+# bats test_tags=slow
+@test "no chaos version label if no chaos" {
+  _deploy_app
+
+  run $ABRA app rollback "$TEST_APP_DOMAIN" \
+    --no-input --no-converge-checks
+  assert_success
+
+  run $ABRA app labels "$TEST_APP_DOMAIN" --no-input
+  assert_success
+  refute_output --regexp "coop-cloud.abra-test-recipe.$TEST_SERVER.chaos-version"
+}

tests/integration/app_rollback_overview.bats

@@ -20,6 +20,7 @@ setup(){
 
 teardown(){
   _undeploy_app
+  _reset_app
   _reset_recipe
 }
 
@@ -36,9 +37,8 @@ teardown(){
   assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0" 
   assert_output --regexp 'CHAOS.*false'
 
-  # new deployment
+  # rollback
   assert_output --regexp 'VERSION.*' + "0.1.0+1.20.0" 
-  assert_output --regexp 'CHAOS.*false'
 
   # env version
   assert_output --regexp 'CURRENT VERSION.*' + "0.2.0+1.21.0"
@@ -62,9 +62,8 @@ teardown(){
   assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0" 
   assert_output --regexp 'CHAOS.*false'
 
-  # new deployment
+  # rollback
   assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0"
-  assert_output --regexp 'CHAOS.*false'
 
   # env version
   assert_output --regexp 'CURRENT VERSION.*' + "0.2.0+1.21.0"
@@ -74,3 +73,30 @@ teardown(){
     "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
   assert_success
 }
+
+@test "app rollback no .env version" {
+  run $ABRA app deploy "$TEST_APP_DOMAIN" "0.2.0+1.21.0" \
+    --no-input --no-converge-checks
+  assert_success
+
+  _wipe_env_version
+
+  run $ABRA app rollback "$TEST_APP_DOMAIN" "0.1.0+1.20.0" \
+    --no-input --no-converge-checks
+  assert_success
+
+  # current deployment
+  assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0"
+  assert_output --regexp 'CHAOS.*false'
+
+  # rollback
+  assert_output --regexp 'VERSION.*' + "0.1.0+1.20.0"
+
+  # env version
+  assert_output --regexp 'CURRENT VERSION.*N/A'
+  assert_output --regexp 'NEW VERSION.*' + "0.2.0+1.21.0"
+
+  run grep -q "TYPE=$TEST_RECIPE:${latestRelease}" \
+    "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
+  assert_success
+}

tests/integration/app_upgrade.bats

@@ -239,3 +239,16 @@ teardown(){
   assert_failure
   assert_output --partial "not a known version"
 }
+
+# bats test_tags=slow
+@test "no chaos version label if no chaos" {
+  _deploy_app
+
+  run $ABRA app upgrade "$TEST_APP_DOMAIN" \
+    --no-input --no-converge-checks
+  assert_success
+
+  run $ABRA app labels "$TEST_APP_DOMAIN" --no-input
+  assert_success
+  refute_output --regexp "coop-cloud.abra-test-recipe.$TEST_SERVER.chaos-version"
+}

tests/integration/app_upgrade_overview.bats

@@ -35,7 +35,7 @@ teardown(){
   assert_output --regexp 'VERSION.*' + "0.1.0+1.20.0"
   assert_output --regexp 'CHAOS.*false'
 
-  # new deployment
+  # upgrade
   assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0" 
   assert_output --regexp 'CHAOS.*false'
 
@@ -61,7 +61,7 @@ teardown(){
   assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0" 
   assert_output --regexp 'CHAOS.*false'
 
-  # new deployment
+  # upgrade
   assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0"
   assert_output --regexp 'CHAOS.*false'
 
@@ -73,3 +73,33 @@ teardown(){
     "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
   assert_success
 }
+
+@test "app upgrade no .env version" {
+  latestRelease=$(_latest_release)
+
+  run $ABRA app deploy "$TEST_APP_DOMAIN" "0.2.0+1.21.0" \
+    --no-input --no-converge-checks
+  assert_success
+
+  _wipe_env_version
+
+  run $ABRA app upgrade "$TEST_APP_DOMAIN" \
+    --no-input --no-converge-checks --force
+  assert_success
+
+  # current deployment
+  assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0"
+  assert_output --regexp 'CHAOS.*false'
+
+  # upgrade
+  assert_output --regexp 'VERSION.*' + "0.2.0+1.21.0"
+  assert_output --regexp 'CHAOS.*false'
+
+  # env version
+  assert_output --regexp 'CURRENT VERSION.*N/A'
+  assert_output --regexp 'NEW VERSION.*' + "0.2.0+1.21.0"
+
+  run grep -q "TYPE=$TEST_RECIPE:${latestRelease}" \
+    "$ABRA_DIR/servers/$TEST_SERVER/$TEST_APP_DOMAIN.env"
+  assert_success
+}