toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: don't always set chaos label, missing .env version N/A handling #479

Merged
decentral1se merged 4 commits from upgrade-old-version-fix into main 2025-01-09 11:03:39 +00:00
Conversation 3 Commits 4 Files Changed 12 +121 -14
decentral1se commented 2025-01-09 10:37:54 +00:00
Owner
Copy Link

Bonus bugs from #478 inspection.

  • run all the integration test files affected ✅
Bonus bugs from https://git.coopcloud.tech/toolshed/abra/issues/478 inspection. - [x] run all the integration test files affected ✅
p4u1 commented 2025-01-09 10:54:03 +00:00
Member
Copy Link
+		if !internal.Chaos {

Should this be if internal.Chaos instead?

``` + if !internal.Chaos { ``` Should this be `if internal.Chaos` instead?
p4u1 commented 2025-01-09 10:54:46 +00:00
Member
Copy Link
+		if !internal.Chaos {

Should this be  if internal.Chaos  instead?

``` + if !internal.Chaos { ``` Should this be  `if internal.Chaos`  instead?
decentral1se force-pushed upgrade-old-version-fix from 56f863eee1 to 41e514ae9a 2025-01-09 10:54:49 +00:00 Compare
decentral1se commented 2025-01-09 11:02:09 +00:00
Author
Owner
Copy Link

@p4u1 yes 😂 thanks for the review, i saw that error and just had to get up for a stretch and a break. literally the opposite of what i am trying to achieve in this change hahahaha

@p4u1 yes 😂 thanks for the review, i saw that error and just had to get up for a stretch and a break. literally the opposite of what i am trying to achieve in this change hahahaha
decentral1se merged commit 41e514ae9a into main 2025-01-09 11:03:39 +00:00
decentral1se deleted branch upgrade-old-version-fix 2025-01-09 11:03:39 +00:00
decentral1se added this to the abra v0.10.0 project 2025-01-09 11:04:08 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:00:59 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:01:01 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:08 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:10 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-19 07:28:29 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-21 17:48:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project abra v0.10.0
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#479
No description provided.
Delete Branch "upgrade-old-version-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?