toolshed/abra
4
3
Fork 19
Code Issues 39 Pull Requests 4 Packages Releases 42 Activity

fix: Changes how the deploy version is detected in app deploy command #493

Merged
decentral1se merged 3 commits from p4u1/abra:fix-deploy-env into main 2025-02-11 10:01:45 +00:00
Conversation 3 Commits 3 Files Changed 4 +93 -44
p4u1 commented 2025-01-30 13:21:32 +00:00
Member
Copy Link

Changes how the deploy version is detect in app deploy command. Below is the before and after behaviour. Both time trying the steps until it found a version to deploy.

Old Behaviour:

  1. version from cli argument
  2. version from .env file, if it was deployed before
  3. latest version

New Behaviour:

  1. version from cli argument
  2. version from .env file
  3. version from deployed app or latest version, if it was not deployed before

Discussed this briefly with @3wordchant at the last kite-flying hour
@decentral1se What do you think about this?

TODO:

  • update tests
Changes how the deploy version is detect in `app deploy` command. Below is the before and after behaviour. Both time trying the steps until it found a version to deploy. **Old Behaviour:** 1. version from cli argument 2. version from .env file, if it was deployed before 3. latest version **New Behaviour:** 1. version from cli argument 2. version from .env file 3. version from deployed app or latest version, if it was not deployed before Discussed this briefly with @3wordchant at the last kite-flying hour @decentral1se What do you think about this? TODO: - [x] update tests
p4u1 added 1 commit 2025-01-30 13:21:32 +00:00
fix: Sorts git tags with tagcmp 87663b95c2
p4u1 force-pushed fix-deploy-env from f99172a32d to 63c10fb3b4 2025-01-30 13:24:16 +00:00 Compare
decentral1se added this to the abra v0.10.0 project 2025-02-05 15:18:08 +00:00
decentral1se commented 2025-02-05 15:22:11 +00:00
Owner
Copy Link

@p4u1 @3wordchant this seems legit to me!

We can also document this clearly for the rest as well.

With a small revision, we have 4 steps then?

  1. version from cli argument
  2. version from .env file
  3. version from deployed app
  4. version from catalogue (if undeployed)

Would definitely appreciate the extra tests.

(I'm happy to see a change coming here as I put a lottttt of time into refactoring this previously extremely spaghetti code into something that is easier to follow...)

Thanks!

@p4u1 @3wordchant this seems legit to me! We can also document this clearly for the rest as well. With a small revision, we have 4 steps then? > 1. version from cli argument > 1. version from .env file > 1. version from deployed app > 1. version from catalogue (if undeployed) Would definitely appreciate the extra tests. (I'm happy to see a change coming here as I put a lottttt of time into refactoring this previously extremely spaghetti code into something that is easier to follow...) Thanks!
p4u1 force-pushed fix-deploy-env from 4577ae753d to 33d5885f6f 2025-02-10 13:45:40 +00:00 Compare
p4u1 commented 2025-02-10 13:46:19 +00:00
Author
Member
Copy Link

@decentral1se I updated the tests. This should be ready for review now :)

@decentral1se I updated the tests. This should be ready for review now :)
decentral1se approved these changes 2025-02-11 10:01:39 +00:00
decentral1se left a comment
Owner
Copy Link

❤️‍🔥

❤️‍🔥
decentral1se merged commit d09a19a385 into main 2025-02-11 10:01:45 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:00:59 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:01:01 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:08 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:10 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-19 07:28:29 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-21 17:48:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project abra v0.10.0
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#493
No description provided.
Delete Branch "p4u1/abra:fix-deploy-env"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?