toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: latest commit for new recipe version #529

Merged
decentral1se merged 2 commits from fix-new-recipe-no-version into main 2025-04-14 22:00:26 +00:00
Conversation 2 Commits 2 Files Changed 4 +31 -5
decentral1se commented 2025-04-14 09:37:49 +00:00
Owner
Copy Link

Closes #527

I do not for the life of me understand how this common workflow had no test 😅

I can't seem to rebase away the previous commit 🤔 I think it's a bug in Gitea...

Closes https://git.coopcloud.tech/toolshed/abra/issues/527 I do not for the life of me understand how this common workflow had no test 😅 I can't seem to rebase away [the previous commit](https://git.coopcloud.tech/toolshed/abra/commit/2b9a185aff4a78338c599abf299bd616cb3bb375) 🤔 I think it's a bug in Gitea...
decentral1se added 2 commits 2025-04-14 09:37:50 +00:00
fix: latest commit for new recipe version
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
fb6e4150ba 
See #527
decentral1se force-pushed fix-new-recipe-no-version from fb6e4150ba to 0ef51e7ccf 2025-04-14 09:38:17 +00:00 Compare
decentral1se requested review from p4u1 2025-04-14 09:40:22 +00:00
decentral1se added this to the abra v0.10.0 project 2025-04-14 09:40:30 +00:00
decentral1se moved this to In Progress in abra v0.10.0 on 2025-04-14 09:40:52 +00:00
p4u1 commented 2025-04-14 13:18:29 +00:00
Member
Copy Link

Why is this not covered by line 91?

Why is this not covered by line 91?
decentral1se force-pushed fix-new-recipe-no-version from 0ef51e7ccf to 742a726778 2025-04-14 21:55:30 +00:00 Compare
decentral1se commented 2025-04-14 21:58:54 +00:00
Author
Owner
Copy Link

Why is this not covered by line 91?

Ah, good call, I've moved the change into that block. Nothing was setting the version in that specific code path.

I see a lot of changes in the log relating to the handling of the version. It seems likely that this was just always working (without a test) and somehow a refactor somewhere broke it. Or it was always broken 🙃 I think we're good now.

> Why is this not covered by line 91? Ah, good call, I've moved the change into that block. Nothing was setting the version in that specific code path. I see a lot of changes in the log relating to the handling of the version. It seems likely that this was just always working (without a test) and somehow a refactor somewhere broke it. Or it was always broken 🙃 I think we're good now.
👍 1
decentral1se merged commit 742a726778 into main 2025-04-14 22:00:26 +00:00
decentral1se deleted branch fix-new-recipe-no-version 2025-04-14 22:00:26 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:00:59 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:01:01 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:08 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:10 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-19 07:28:29 +00:00
decentral1se moved this to Done in abra v0.10.0 on 2025-04-21 17:48:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
p4u1
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project abra v0.10.0
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#529
No description provided.
Delete Branch "fix-new-recipe-no-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?