fix: latest commit for new recipe version #529

2025-04-14T09:37:49Z

decentral1se commented

2025-04-14 09:37:49 +00:00

Closes #527

I do not for the life of me understand how this common workflow had no test 😅

I can't seem to rebase away the previous commit 🤔 I think it's a bug in Gitea...

Closes https://git.coopcloud.tech/toolshed/abra/issues/527 I do not for the life of me understand how this common workflow had no test 😅 I can't seem to rebase away [the previous commit](https://git.coopcloud.tech/toolshed/abra/commit/2b9a185aff4a78338c599abf299bd616cb3bb375) 🤔 I think it's a bug in Gitea...

decentral1se added 2 commits 2025-04-14 09:37:50 +00:00

build: go mod tidy 2b9a185aff

fix: latest commit for new recipe version

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

fb6e4150ba

See #527

decentral1se force-pushed fix-new-recipe-no-version from fb6e4150ba to 0ef51e7ccf

2025-04-14 09:38:17 +00:00

Compare

decentral1se requested review from p4u1 2025-04-14 09:40:22 +00:00

decentral1se added this to the abra v0.10.0 project 2025-04-14 09:40:30 +00:00

decentral1se moved this to In Progress in abra v0.10.0 on 2025-04-14 09:40:52 +00:00

p4u1 commented

2025-04-14 13:18:29 +00:00

Why is this not covered by line 91?

decentral1se force-pushed fix-new-recipe-no-version from 0ef51e7ccf to 742a726778

2025-04-14 21:55:30 +00:00

Compare

decentral1se commented

2025-04-14 21:58:54 +00:00

Why is this not covered by line 91?

Ah, good call, I've moved the change into that block. Nothing was setting the version in that specific code path.

I see a lot of changes in the log relating to the handling of the version. It seems likely that this was just always working (without a test) and somehow a refactor somewhere broke it. Or it was always broken 🙃 I think we're good now.

> Why is this not covered by line 91? Ah, good call, I've moved the change into that block. Nothing was setting the version in that specific code path. I see a lot of changes in the log relating to the handling of the version. It seems likely that this was just always working (without a test) and somehow a refactor somewhere broke it. Or it was always broken 🙃 I think we're good now.

👍 1

decentral1se merged commit 742a726778 into main

2025-04-14 22:00:26 +00:00

decentral1se deleted branch fix-new-recipe-no-version

2025-04-14 22:00:26 +00:00

decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:00:59 +00:00

decentral1se moved this to Done in abra v0.10.0 on 2025-04-14 22:01:01 +00:00

decentral1se referenced this pull request

2025-04-15 08:52:41 +00:00

fix: don't overwrite recipeVersion #533

decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:08 +00:00

decentral1se moved this to Done in abra v0.10.0 on 2025-04-16 05:16:10 +00:00