toolshed/abra
4
2
Fork 18
Code Issues 24 Pull Requests Packages Releases 41 Activity

fix: Does not error when recipes folder does not exist in app new #552

Merged
decentral1se merged 2 commits from p4u1/abra:app-new-first-time into main 2025-08-11 12:47:44 +00:00
Conversation 4 Commits 2 Files Changed 1 +6 -6
p4u1 commented 2025-04-25 08:11:10 +00:00
Member
Copy Link
No description provided.
p4u1 added 1 commit 2025-04-25 08:11:10 +00:00
fix: Does not error when recipes folder does not exist in app new
Some checks failed
continuous-integration/drone/pr Build is failing
Details
508a7491b3
decentral1se reviewed 2025-04-25 08:44:25 +00:00
decentral1se left a comment
Owner
Copy Link

Nice! Can we get a test with this also? Otherwise, we're too easily getting regressions 🙏

Nice! Can we get a test with this also? Otherwise, we're too easily getting regressions 🙏
decentral1se added this to the Abra v0.11.x project 2025-04-25 09:16:55 +00:00
decentral1se moved this to In Progress in Abra v0.11.x on 2025-04-25 09:17:08 +00:00
p4u1 commented 2025-04-25 09:50:10 +00:00
Author
Member
Copy Link

I would love to write a test, but integration test is not possible, because it does not trigger with --no-input and a unit test is also not possible, because the function makes a dozen calls into the universe. This will need some serious refactoring, before we can test stuff like this :(

I would love to write a test, but integration test is not possible, because it does not trigger with --no-input and a unit test is also not possible, because the function makes a dozen calls into the universe. This will need some serious refactoring, before we can test stuff like this :(
decentral1se commented 2025-04-25 13:59:45 +00:00
Owner
Copy Link

OK yeh, fair enough 👍 I'd probably just log.Debug this or even skip the error altogether since abra will re-create the recipes dir on any further logic. It would seem to be a weird state to end up in but not something the user really needs to care about when it gets resolved internally? Merge away anyway with whatever you're happy with.

OK yeh, fair enough 👍 I'd probably just `log.Debug` this or even skip the error altogether since `abra` will re-create the recipes dir on any further logic. It would seem to be a weird state to end up in but not something the user really needs to care about when it gets resolved internally? Merge away anyway with whatever you're happy with.
👍 1
decentral1se moved this to In Progress in Abra v0.11.x on 2025-05-11 08:24:48 +00:00
decentral1se moved this to Stalled in Abra v0.11.x on 2025-07-08 10:08:00 +00:00
p4u1 added 1 commit 2025-08-11 09:40:13 +00:00
change to debug log a4d53a1fe5
p4u1 commented 2025-08-11 09:40:23 +00:00
Author
Member
Copy Link

Changed it to a debug log

Changed it to a debug log
🎉 1
decentral1se merged commit 3fae036db2 into main 2025-08-11 12:47:44 +00:00
decentral1se moved this to Done in Abra v0.11.x on 2025-08-12 05:21:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Abra v0.11.x
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jmakdah2 kawaiipunk knoflook kolaente lambdabundesverband moritz p4u1 renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#552
No description provided.
Delete Branch "p4u1/abra:app-new-first-time"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?