feat: Retrieves auth token from image #585
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: toolshed/abra#585
Reference in New Issue
Block a user
No description provided.
Delete Branch "p4u1/abra:private-registry"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This allows using a private registry for an image.
To use it, you have to run docker login on your local machine before
running abra deploy.
4a0f677e40toce3cd85271Great stuff, thanks! We wanted this since ages ago: toolshed/organising#121
Would you be able to add some docs for this also? A small entry in https://docs.coopcloud.tech/operators/handbook/.
Few small comments.
@ -449,0 +455,4 @@if sendAuth {dockerCLI, err := command.NewDockerCli()if err != nil {log.Errorf("failed create docker cli: %s", err)An error like this will be very confusing without context, maybe we need to add more? E.g.
log.Errorf("retrieving docker auth token: failed create docker cli: %s", err)I updated the error message
@ -588,3 +605,3 @@)if err := os.MkdirAll(filepath.Join(config.LOGS_DIR, opts.ServerName), 0764); err != nil {if err := os.MkdirAll(filepath.Join(config.LOGS_DIR, opts.ServerName), 0o764); err != nil {This seems unrelated, are you sure this won't break things?
this is a change by the formatter, and is semantically the same
ce3cd85271to7a24bf9cd54dea3ac3ca