toolshed/abra
4
3
Fork 19
Code Issues 39 Pull Requests 4 Packages Releases 42 Activity

Warn instead of error on lint checks during --chaos deploy, and show all linting errors at once #588

Merged
3wordchant merged 4 commits from calix/497 into main 2025-08-12 12:18:40 +00:00
Conversation 1 Commits 4 Files Changed 3 +52 -13
3wordchant commented 2025-08-12 12:10:43 +00:00
Owner
Copy Link

Closes toolshed/organising#497

➜ abra app deploy test.example.com  
FATA recipe failed lint checks:
* traefik routing enabled (R010)
* all services have images (R011)

➜ abra app deploy test.example.com --chaos
WARN recipe failed lint checks:
* traefik routing enabled (R010)
* all services have images (R011)
(deploy continues)
Closes toolshed/organising#497 ``` ➜ abra app deploy test.example.com FATA recipe failed lint checks: * traefik routing enabled (R010) * all services have images (R011) ➜ abra app deploy test.example.com --chaos WARN recipe failed lint checks: * traefik routing enabled (R010) * all services have images (R011) (deploy continues) ```
3wordchant added 3 commits 2025-08-12 12:10:44 +00:00
WARN on recipe linting errors during --chaos..
Some checks failed
continuous-integration/drone/push Build is failing
Details
ef77db1559 
..and show multiple linting errors instead of bailing on the first one.

Re #497
Reformat linting errors in LintForErrors aa7d8789eb 
See toolshed/organising#497 (comment)
Add integration tests for new "--chaos to blast past lint errors"
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
e49ad09408 
Re toolshed/organising#497
3wordchant added 1 commit 2025-08-12 12:13:47 +00:00
Appease formatter
All checks were successful
continuous-integration/drone/push Build is passing
Details
f55b01b85d
decentral1se approved these changes 2025-08-12 12:18:06 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM 💟

LGTM 💟
❤️ 1
3wordchant force-pushed calix/497 from f55b01b85d to 032fe99086 2025-08-12 12:18:33 +00:00 Compare
3wordchant merged commit 032fe99086 into main 2025-08-12 12:18:40 +00:00
3wordchant deleted branch calix/497 2025-08-12 12:18:40 +00:00
decentral1se added this to the Abra v0.11.x project 2025-08-12 12:19:49 +00:00
decentral1se moved this to Done in Abra v0.11.x on 2025-08-12 12:20:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
installer
Everything to do with the install script.
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Abra v0.11.x
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#588
No description provided.
Delete Branch "calix/497"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?