toolshed/abra
4
2
Fork 18
Code Issues 24 Pull Requests Packages Releases 41 Activity

fix: more robust abra recipe release -p failure handling #610

Merged
decentral1se merged 1 commits from fix/576 into main 2025-08-24 12:05:04 +00:00
Conversation 1 Commits 1 Files Changed 2 +100 -25
decentral1se commented 2025-08-24 11:18:08 +00:00
Owner
Copy Link

See #576

This is sadly very hard to test with the integration suite, so relying on Good 'Ol Manual Testing.

Changes:

  • Error handlings bubbles up correctly to the main Run code path
  • --help output deals with the ssh-agent better now
  • If SSH_AUTH_SOCK is not present, a helpful error message is outputted
  • If --publish/-p fails, the commit/tag is rolledback so it is possible to run abra recipe release -p again
    • No changes are lost, using a git reset HEAD~1 approach
See https://git.coopcloud.tech/toolshed/abra/issues/576 This is sadly very hard to test with the integration suite, so relying on Good 'Ol Manual Testing. Changes: * Error handlings bubbles up correctly to the main `Run` code path * `--help` output deals with the `ssh-agent` better now * If `SSH_AUTH_SOCK` is not present, a helpful error message is outputted * If `--publish/-p` fails, the commit/tag is rolledback so it is possible to run `abra recipe release -p` again * No changes are lost, using a `git reset HEAD~1` approach
decentral1se added 1 commit 2025-08-24 11:18:08 +00:00
fix: more robust -p failure handling
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
4cb660c348 
See #576
decentral1se added this to the Abra v0.11.x project 2025-08-24 11:18:09 +00:00
decentral1se moved this to In Progress in Abra v0.11.x on 2025-08-24 11:45:43 +00:00
decentral1se commented 2025-08-24 12:05:00 +00:00
Author
Owner
Copy Link

OK I think this is safe to proceed with 🤞

OK I think this is safe to proceed with 🤞
decentral1se merged commit 4cb660c348 into main 2025-08-24 12:05:04 +00:00
decentral1se deleted branch fix/576 2025-08-24 12:05:04 +00:00
decentral1se moved this to Done in Abra v0.11.x on 2025-08-24 12:08:09 +00:00
decentral1se removed this from the Abra v0.11.x project 2025-08-30 10:14:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
easy-first-issue
Something for new people to get stuck into. We hope it's easy!
enhancement
New feature
help wanted
Need some help
i10n
Everything to do with localisation
i18n
Everything to do with internationalisation
invalid
Something is wrong
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jmakdah2 kawaiipunk knoflook kolaente lambdabundesverband moritz p4u1 renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#610
No description provided.
Delete Branch "fix/576"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?