fix: chaos handling fixes #674
Reference in New Issue
Block a user
No description provided.
Delete Branch "fix/668"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Started down the rabbit hole that is #668. Unsurprisingly there was a bug (
3696d63a34) in how we display the chaos version in nearly every overview and fixing this caused the house of cards to fall down (the rest of the commits) 😆. The TLDR; is that we actually were overwriting the standard version label (e.g.coop-cloud.RECIPE_MY_APP.version) with the chaos version which was causingabrato choke. Even if we have a chaos version (commit SHA or unstaged (+U)), we know the stable version because it is in the compose configuration in parallel. When we preserve this in the label we can always then feed this toupgrade/rollback, resolving the main use-case blocker in #668.You can once more do the following without running into an error:
abra app deploy 1312.net... make unstaged changes in the recipe...abra app deploy 1312.net --chaosabra app upgrade 1312.netThe only remaining
abraexplosion is when you undeploy a chaos version with unstaged changes, reset the changes and try to deploy it again. The improved error message described in #668 (comment) is now provided. The deploy overviews will also show the chaos version more consistently. Thanks to #657 we now see a lot more of what is changing. I think I even managed to fix #557 also 🙃e612bd610fto4d33a24a07WIP: fix: chaos handling fixesto fix: chaos handling fixes