WIP: fix(recipe): Prevent crash when recipe has no previous tag or release #706

2025-10-27T19:14:08Z

p4u1 commented

2025-10-27 19:14:08 +00:00

No description provided.

p4u1 added 1 commit 2025-10-27 19:14:08 +00:00

fix(recipe): Prevent crash when recipe has no previous tag or release

continuous-integration/drone/pr Build is failing

Details

dc0cc20141

decentral1se reviewed 2025-10-28 12:26:33 +00:00

decentral1se left a comment

Thanks @p4u1.

One comment, as I'm not quite sure on the approach.

And an integration test, which creates a new recipe and syncs it, would be great.

🙏

Thanks @p4u1. One comment, as I'm not quite sure on the approach. And an integration test, which creates a new recipe and syncs it, would be great. 🙏

cli/recipe/sync.go Outdated

						
				@@ -132,3 +133,3 @@

							}

							latestRelease := tags[len(tags)-1]

							latestRelease := "0.0.0+0.0.0"

decentral1se commented

2025-10-28 12:23:51 +00:00

Isn't the left-hand side supposed to be 1.0.0 / 0.1.0 following:

		abra/cli/recipe/sync.go
		Lines 85 to 100 in 11656c009d
	
							fmt.Println(i18n.G(`

				The following options are two types of initial semantic version that you can

				pick for %s that will be published in the recipe catalogue. This follows the

				semver convention (more on https://semver.org), here is a short cheatsheet

				    0.1.0: development release, still hacking. when you make a major upgrade

				           you increment the "y" part (i.e. 0.1.0 -> 0.2.0) and only move to

				           using the "x" part when things are stable.

				    1.0.0: public release, assumed to be working. you already have a stable

				           and reliable deployment of this app and feel relatively confident

				           about it.

				If you want people to be able alpha test your current config for %s but don't

				think it is quite reliable, go with 0.1.0 and people will know that things are

				likely to change.

I thought this case was covered 🤔 The logic of the code above doesn't look right because it tests len(tags) == 0 and then access tags later on 😬 I would assume if have no previous release/tag we can construct a choice from the above question and the tag of the app? Otherwise, probably 0.0.0+0.0.0 is going to explode somewhere else 🙃

Isn't the left-hand side supposed to be `1.0.0` / `0.1.0` following: https://git.coopcloud.tech/toolshed/abra/src/commit/11656c009df0f6acb272a0614b12264cf08e82e5/cli/recipe/sync.go#L85-L100 I thought this case was covered 🤔 The logic of the code above doesn't look right because it tests `len(tags) == 0` and then access `tags` later on 😬 I would assume if have no previous release/tag we can construct a choice from the above question and the tag of the `app`? Otherwise, probably `0.0.0+0.0.0` is going to explode somewhere else 🙃

p4u1 force-pushed fix-crash-sync from dc0cc20141 to e11f775260

2025-11-03 16:26:16 +00:00

Compare

p4u1 commented

2025-11-04 08:58:45 +00:00

@decentral1se thanks for the review. I still have to dive deeper into this... I'm just adding fixes while working on a new recipe and abra panicing

👍 1

decentral1se marked the pull request as work in progress 2025-11-04 13:54:26 +00:00

decentral1se commented

2025-11-09 09:50:06 +00:00

@p4u1 I wired up a bunch of tests to cover some cases where this might have been going wrong: ce1aa3d870

It doesn't seem to be failing in any obvious way? I'd be curious if you can reproduce your stack trace?

Bonus: it's actually not that bad to simulate user input with the 'ol bash -c "echo ... | ..." trick!

@p4u1 I wired up a bunch of tests to cover some cases where this might have been going wrong: ce1aa3d8705ad0291f0cb3e45888892d99ebc714 It doesn't seem to be failing in any obvious way? I'd be curious if you can reproduce your stack trace? Bonus: it's actually not that bad to simulate user input with the 'ol `bash -c "echo ... | ..."` trick!

p4u1 referenced this pull request

2025-12-12 08:47:15 +00:00

panic: interface conversion: reference.repository is not reference.NamedTagged: missing method Tag #731

decentral1se referenced this pull request

2025-12-19 10:18:37 +00:00

avoiding #732 by checking for empty versions list for recipe sync #738

decentral1se commented

2025-12-21 15:37:45 +00:00

#738

https://git.coopcloud.tech/toolshed/abra/pulls/738

jeppebundsgaard commented

2025-12-23 22:58:25 +00:00

First-time contributor

I am trying to develop a recipe for Friendica. I think I ran into this problem. I run this command for the first time:

abra app deploy friendica.example.dk --chaos

And I get:

panic: interface conversion: reference.repository is not reference.NamedTagged: missing method Tag

Do you have a quick fix I can use, while you get the fix into abra release?
Thanks!!

I am trying to develop a recipe for Friendica. I think I ran into this problem. I run this command for the first time: `abra app deploy friendica.example.dk --chaos` And I get: > panic: interface conversion: reference.repository is not reference.NamedTagged: missing method Tag Do you have a quick fix I can use, while you get the fix into abra release? Thanks!!

decentral1se commented

2025-12-23 23:21:17 +00:00

@jeppebundsgaard can you open up a new issue with the output of the command while using --debug? Thanks!

@jeppebundsgaard can you open up a new issue with the output of the command while using `--debug`? Thanks!

jeppebundsgaard referenced this pull request

2025-12-23 23:30:15 +00:00

panic: interface conversion: reference.repository is not reference.NamedTagged: missing method Tag #739

p4u1 closed this pull request

2025-12-30 14:09:05 +00:00